Create directory for socket (only the last directory) #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericonr
reviewed
Jul 13, 2024
| @@ -17,6 +17,7 @@ | |||
| #include "modules.h" | |||
| #include "parse.h" | |||
| #include "util.h" | |||
| #include "libgen.h" | |||
There was a problem hiding this comment.
This should be in the first list of includes, as #include <libgen.h>, since it is a system header.
Comment on lines
+218
to
+222
| // create only the last directory not recursive mode | ||
| struct stat st = {0}; | ||
| if (stat(dirname(socket_path), &st) == -1) { | ||
| mkdir(dirname(socket_path), 0755); | ||
| } |
There was a problem hiding this comment.
This isn't in the right place, directory creation should happen before the bind() attempt. We should also consider only doing it in case bind returns an error indicating the directory doesn't exist, instead of using stat to check for directory existence (access or readlink would be lighterweight options, btw).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope that could be a good fix and the good way to proceed , it's first time I write C