Regression can only set one value

[think-free]

With last update I can only set one cookie at a time :

This :

                    var cookies = new Cookies( req, res, null );

                    cookies.set( "user", user, {  httpOnly: true } )
                    cookies.set( "session", session, {  httpOnly: true } );

                    res.json({status : "ok"});

work with previous version but not by the last one.

Only the last (session one) set works ...

[jed]

well, that's no good. @mtkopone, would you mind taking a look at your last commit?

[mtkopone]

Hi.
I'm having trouble reproducing this.

Assumed from res.json(...) that you're using express.

Wrote a test case in my fork for this, but it passes:
https://github.com/mtkopone/cookies/blob/fix-express-cookie-duplication/test/issue-20.js

One thing that might be relevant is the version of express you are using?

[jed]

@think-free, let me know if the latest commit is now working for you, okay?

[jedrichards]

Hey ... I think I just had this issue too. Only the last cookie set was making it into the response headers. I'm using Restify not Express. Updating from 0.3.4 > 0.3.5 fixed it for me. Thx! ^^

[think-free]

Hi !
Same here, using restify not express.
I don't have a lot of time to test the last commit. I'll try to test it tomorrow ...
I can try to make a snippet reproducing this bug if the last commit doesn't solve the problem.
I'll tell you tomorrow ;)
Thanks

[mtkopone]

My bad. Didn't know people we using this with restify.

But should be fixed in 0.3.5.

Also, I wrote a test for restify, which is coming in a pull request.

[jed]

the new restify tests from @mtkopone pass, so i'm going to assume this is fixed. let me know if you have any issues, @think-free.