Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose router engine for other implementations #29

Closed
wants to merge 1 commit into from

Conversation

blakeembrey
Copy link
Member

From #13.

Closes #12.

Implements custom path implementations via router inheritance.

Edit: I also still prefer the simplicity of this PR over #22. If you think about it this way it's cleaner - the router engine is the most basic router which takes a function as the "path matcher". Other implementations can build on this to take strings and regexps, etc. The path accepted for route and use can be though of as the "label" for debugging (and backward compat).

@blakeembrey blakeembrey force-pushed the router-inheritance branch 2 times, most recently from 31c381b to 037d09c Compare November 13, 2015 00:23
blakeembrey added a commit to blakeembrey/router that referenced this pull request Nov 13, 2015
* Router inheritance (pillarjs#29)
* Router exiting (pillarjs#30)
@blakeembrey
Copy link
Member Author

@dougwilson Any chance we'll be able to review these sometime? It's been a more than a year (#13) 😮 Otherwise I can look at pulling out the inheritance pieces, I'd love to get a more stable base to continue using (https://www.npmjs.com/package/osprey).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Router Engine
2 participants