Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user secrets #115 #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add user secrets #115 #116

wants to merge 1 commit into from

Conversation

kgday
Copy link

@kgday kgday commented Dec 3, 2023

Ability to add dotnet user secrets json configuration in the configuration builder.

type ConfigBuilderSpec =
{ AddEnvVars : bool
BasePath : string
RequiredFiles : ConfigFile list
OptionalFiles : ConfigFile list
InMemory : Map<string, string> }
InMemory : Map<string, string>
AddUserSecrets: bool}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a space here to separate the type from the bracket.

@@ -51,6 +54,9 @@ type ConfigBuilder (args : string[]) =

bldr.AddCommandLine(args) |> ignore

if conf.AddUserSecrets then
Copy link
Owner

@pimbrouwers pimbrouwers Dec 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should appear before env vars, I try to match the prior specified here: https://learn.microsoft.com/en-us/dotnet/core/extensions/configuration.

image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goido. I'll fix that.

@@ -101,6 +107,11 @@ type ConfigBuilder (args : string[]) =
member _.AddOptionalJsonFile (conf : ConfigBuilderSpec, filePath : string) =
{ conf with OptionalFiles = (JsonFile filePath) :: conf.OptionalFiles }

///Adds optional user secrets to the ConfigurationBuilder.
[<CustomOperation("optional_user_secrets")>]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the non-optional brother of this omitted on purpose?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes because it is generally only used in the Development environment. In the default web builder of the c# template where it sets up all the config for you it only adds optional user secrets if the env is development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants