Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Make Dependencies tab hideable via config #549

Merged
merged 1 commit into from
Jun 18, 2024
Merged

[Improvement]: Make Dependencies tab hideable via config #549

merged 1 commit into from
Jun 18, 2024

Conversation

kingjia90
Copy link
Contributor

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
76.8% Duplication on New Code

See analysis details on SonarCloud

@kingjia90 kingjia90 mentioned this pull request Jun 4, 2024
Merged
@markus-moser markus-moser mentioned this pull request Jun 17, 2024
Closed
@markus-moser
Copy link
Contributor

For the web2print documents we would need to do the check for the dependencies tab too:

pimcore/web-to-print-bundle#78

@markus-moser markus-moser self-requested a review June 17, 2024 12:35
@kingjia90 kingjia90 mentioned this pull request Jun 17, 2024
Merged
@markus-moser markus-moser added this to the 1.5.0 milestone Jun 18, 2024
@kingjia90 kingjia90 merged commit e87b3c7 into 1.x Jun 18, 2024
9 checks passed
@kingjia90 kingjia90 deleted the hideable-dependencies-tab branch June 18, 2024 08:58
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markus-moser markus-moser markus-moser approved these changes

Assignees
No one assigned
Labels
Pimcore:ToDo
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

[Improvement]: Resolve Dependencies via Messenger
3 participants
@kingjia90 @markus-moser @wisconaut