Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Result grid #65

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Fix Result grid #65

merged 1 commit into from
Dec 2, 2019

Conversation

dvesh3
Copy link
Contributor

@dvesh3 dvesh3 commented Nov 21, 2019

Resolves #64

@dvesh3 dvesh3 requested a review from fashxp November 21, 2019 13:52
@dvesh3 dvesh3 added the bug label Nov 21, 2019
@CLAassistant
Copy link

CLAassistant commented Nov 21, 2019

CLA assistant check
All committers have signed the CLA.

@fashxp fashxp merged commit 44ab01c into master Dec 2, 2019
@fashxp fashxp added this to the 2.1.1 milestone Dec 2, 2019
@fashxp fashxp deleted the fix-result-grid branch December 2, 2019 11:02
@wujku
Copy link
Contributor

wujku commented Jan 20, 2020

@fashxp @dvesh3 CSV export not working for Pimcore >= 6.3.x

tbar = tbar.concat(['->', "-", {
text: t("export_csv"),
iconCls: "pimcore_icon_export",
handler: function () {
Ext.MessageBox.show({
title: t('warning'),
msg: t('csv_object_export_warning'),
buttons: Ext.Msg.OKCANCEL,
fn: function (btn) {
if (btn == 'ok') {
this.exportPrepare();
}
}.bind(this),
icon: Ext.MessageBox.WARNING
});
}.bind(this)
}, "-", this.columnConfigButton
]);

this.exportPrepare() calls pimcore.element.helpers.gridColumnConfig.exportPrepare(),
this.element.id was missing.

        var params = {
            filter: filters,
            condition: condition,
            classId: this.classId,
            folderId: this.element.id,
            objecttype: this.objecttype,
            language: this.gridLanguage,
            "ids[]": ids,
            "fields[]": fieldKeys,
            settings: settings,
            query: searchQuery,
            batch: true // to avoid limit for export
        };

@wujku
Copy link
Contributor

wujku commented Jan 20, 2020

@fashxp @dvesh3 When I put at top of pimcore.bundle.advancedObjectSearch.searchConfig.resultPanel:

    element: {
        id: 1
    },

Export prepare data, but when export was completed, I got that error:
Cannot read property 'downloadUrl' of undefined.

https://github.com/pimcore/pimcore/blob/1766b45e47e5b244e4e1a50b1851c9d74c4faabe/bundles/AdminBundle/Resources/public/js/pimcore/element/helpers/gridColumnConfig.js#L687

dvesh3 added a commit that referenced this pull request Jan 20, 2020
dvesh3 added a commit that referenced this pull request Jan 20, 2020
@fashxp
Copy link
Member

fashxp commented Jan 20, 2020

should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search results grid is broken on Pimcore 6.3.0
4 participants