PHP 8.3 with Imagick from master

[youwe-petervanderwal]

With Ubuntu 24.04 out now for a month which is shipped with PHP 8.3 and where Imagick can simply be installed via apt install php-imagick, I don't think we should longer lack behind.

Imagick/imagick#640 has multiple mentions of installing Imagick from master and since that issue is open for half a year already I don't see any version being released soon (sorry for my pessimistic attitude).

I do see this as a temporary solution, of course the manual download should be reverted at the moment Imagic does release the new official version.

Test results:

1. Docker build test is successful (will be triggered again in this PR but wanted to be sure before I opened this one): https://github.com/youwe-petervanderwal/docker/actions/runs/9187199518/job/25264375358
2. Tested pimcore/demo with both PHP 8.2 and 8.3 (locally build Docker images and connected these in the docker-compose), results:

PHP 8.2 test

$ docker-compose exec php php -v
PHP 8.2.19 (cli) (built: May 14 2024 13:16:54) (NTS)

Using Gaussian Blur on Thumbnail definition:

PHP 8.3 test

$ docker-compose exec php php -v
PHP 8.3.7 (cli) (built: May 14 2024 12:46:30) (NTS)

Using Gaussian Blur on Thumbnail definition:

[brusch]

LGTM, I was just thinking about making this part PHP 8.3 only, but since we do not touch stable releases (v3.2) it's fine for now as it is.

[youwe-petervanderwal]

If we would go that direction, for code it is probably the cleanest solution to make the download link dependent on the PHP version, so
PHP 8.3: 28f27044e435a2b203e32675e942eb8de620ee58
PHP 8.2: refs/tags/3.7.0

Alternative would be to have a somewhat larger if statement in your Dockerfile

[ "$PHP_VERSION" == "8.2 ] && \
    pecl install -f imagick && \
    docker-php-ext-enable imagick;

[ "$PHP_VERSION" != "8.2 ] && \
    mkdir -p /usr/src/php/ext/imagick; \
    # Locking on specific commit hash to provide consistent results, at the moment of writing this is the HEAD of master
    curl -fsSL https://github.com/Imagick/imagick/archive/28f27044e435a2b203e32675e942eb8de620ee58.tar.gz | tar xvz -C "/usr/src/php/ext/imagick" --strip 1; \
    docker-php-ext-install imagick;

[youwe-petervanderwal]

If it would make releasing a new version easier I'm happy to make that change, In that case please let me know which option you'd prefer

[brusch]

@youwe-petervanderwal no, fine for me for now. We'll build only 3.x images for PHP 8.3 for now, let's do some tests first and then do the v.3.3 release. If we see some issues with the current approach, we can change it anytime back to use the alternative approach (I'd prefer the second option then 😉).

Merging now. Images will be ready soon then.

[brusch]

@youwe-petervanderwal thanks a lot 😊

[brusch]

Image will be ready when https://github.com/pimcore/docker/actions/runs/9192158816/job/25280144763 is done.

[youwe-petervanderwal]

Thanks @brusch

The development version works now 🚀

# docker-compose.yaml
    php:
        image: pimcore/pimcore:php8.3-debug-v3-dev
        # And the rest of the settings, see pimcore/demo or pimcore/skeleton repositories

    supervisord:
        image: pimcore/pimcore:php8.3-supervisord-v3-dev
        # And the rest of the settings, see pimcore/demo or pimcore/skeleton repositories

ps cross-post to issue #160

[brusch]

@youwe-petervanderwal glad to hear - thanks again for the PR.
Release will follow in a few days, after we did some further testing. 😊