Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] SelectCategory.php: Cast $value to string #156

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

MarkTro
Copy link
Contributor

@MarkTro MarkTro commented Jan 22, 2024

$value can set with an int value (line 73) by "getId()". Trim throws in strict mode an error, if it doesn't get a string. Therefore we need to cast $value to a string.

If $value is set bei "getId()" in line 73, it causes an error within "trim()" in line 73, because it's an integer not a string.
@fashxp fashxp changed the base branch from 1.x to 1.0 January 22, 2024 11:19
@fashxp fashxp self-assigned this Jan 22, 2024
@fashxp fashxp added the Bug label Jan 22, 2024
@fashxp fashxp added this to the 1.0.11 milestone Jan 22, 2024
@fashxp fashxp merged commit 6ebfd3e into pimcore:1.0 Jan 22, 2024
7 checks passed
@fashxp
Copy link
Member

fashxp commented Jan 22, 2024

thx very much!

@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants