Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of RC's $dont_override #11

Merged
merged 7 commits into from
May 26, 2016
Merged

Better handling of RC's $dont_override #11

merged 7 commits into from
May 26, 2016

Conversation

Takika
Copy link
Contributor

@Takika Takika commented Apr 22, 2016

I just made some changes in the preferences handling.

  • Add config file where the admins can define the default config values
  • Fill the $override property (user changable settings)
  • Use this property to limit the preferences hooks
  • Use this property to limit what we show in preferences_list hook

@Takika
Add default config file
d838213
@Takika
Fill the config array
37194af 
This array shows which variables modifiable by the user.
@Takika
Use the new config array
b277bc2
@Takika
Don't hook the preferences if the user can't change anything
ab318fa
@Takika
Change the visibility of the column specific options
fd97de9 
Don't show the column specific options and the title if the user can't change them
@Takika
Change the visibility of the status specific options
631973e 
Don't show the status specific options and the title if the user can't change them
@Takika
Rename the config property to override
526d121
@pimlie pimlie merged commit b45b97b into pimlie:master May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Takika @pimlie