Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix autocompletion for short commands #71

Merged
merged 2 commits into from
Jul 2, 2019

Conversation

ingkebil
Copy link
Contributor

@ingkebil ingkebil commented Jun 30, 2019

Fixes #38

Checklist

  • I have made a change to this repository, be it functionality, testing, documentation, spelling, or grammar.
  • I updated my branch with the master branch.
  • I have added the necessary testing to prove my fix is effective/my feature works (or I did not modify functionality).
  • I have added necessary documentation about the functionality in an appropriate .md file.
  • I have appropriately commented any code I have modified

Short description of what this PR does:

  • The short commands do not autocomplete file names. e.g. notes o <tab><tab> does not yield the files in your $NOTES_DIRECTORY. This PR adds that autocompletion.
  • The search and ls commands were omitted from the autocomplete. This has been added and is covered by the unit tests.

I wasn't sure if this needs extra unit tests. Let me know what you think!

@pimterry
Copy link
Owner

pimterry commented Jul 2, 2019

Nice work! This looks great to me, merging now. Thanks for contributing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocompletion doesn't work for notes o or notes ls
2 participants