Refactoring validate() to handle resource data collections #5

grahamu · 2016-05-07T02:31:11Z

Now validate() yields either a validated resource or a resource generator callable,
depending on the value of new kwarg collection.

Now yields either a validated resource or a resource generator callable, depending on the value of new kwarg `collection`.

grahamu · 2016-05-07T02:44:33Z

Example use for relationship data collections:

        with self.validate(self.resource_class, collection=True) as resource_generator:
            tags = [resource.obj.name for resource in resource_generator()]
            self.object.tags.add(*tags)

grahamu · 2016-05-09T18:45:49Z

@brosner sure would be nice to get this merged!

flake8 is unhappy with Resource.serialize.

coveralls · 2016-05-11T16:14:01Z

Changes Unknown when pulling 29830b2 on grahamu:all-purpose-validate into * on pinax:master*.

@contextlib.contextmanager needed all yield statements inside a try block in order to properly catch validation errors arising from resource manipulation. For instance, resource.save() may raise attribute validation problems that resource.populate() does not.

coveralls · 2016-05-12T05:59:20Z

Changes Unknown when pulling 4ba2a87 on grahamu:all-purpose-validate into * on pinax:master*.

grahamu · 2016-05-12T06:20:31Z

Needs four types of tests.
Testing with other systems indicate this solution works for valid and invalid single resources, and valid resource collections. Invalid resource collections have not been tested. All four test types need to be added.

brosner · 2016-05-12T19:49:44Z

pinax/api/viewsets.py

+                    for resource_data in data["data"]:
+                        yield self.validate_resource(resource_class, resource_data, obj)
+
+                yield gen_func


I think we went the wrong way here. The generator idea was a little ill-conceived on my part. However, I think the fix is very easy and even cleaner. I am changing my mind after seeing the resulting code for the validate caller. Having to call the generator is a bit ugly IMO.

The new idea is to simply change this line to:

yield (self.validate_resource(resource_class, resource_data, obj) for resource_data in data["data"])

The change to the caller is to remove the function call.

Very nice, much cleaner code both ways. Thanks.

coveralls · 2016-05-13T00:37:22Z

Changes Unknown when pulling d1339c1 on grahamu:all-purpose-validate into * on pinax:master*.

Refactoring validate to deal with resource data collections.

8b855f0

Now yields either a validated resource or a resource generator callable, depending on the value of new kwarg `collection`.

grahamu changed the title ~~Refactoring validate() to deal with resource data collections~~ Refactoring validate() to handle resource data collections May 7, 2016

grahamu added 2 commits May 11, 2016 10:01

Merge branch 'master' into all-purpose-validate

ebcd991

Temporary fix for "too complex" flake8 error.

29830b2

flake8 is unhappy with Resource.serialize.

brosner reviewed May 12, 2016
View reviewed changes

Simplifying yield result for collections.

d1339c1

brosner merged commit 8a1a7ce into pinax:master May 13, 2016

grahamu deleted the all-purpose-validate branch May 13, 2016 17:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactoring validate() to handle resource data collections #5

Refactoring validate() to handle resource data collections #5

grahamu commented May 7, 2016

grahamu commented May 7, 2016

grahamu commented May 9, 2016

coveralls commented May 11, 2016 •

edited

Loading

coveralls commented May 12, 2016 •

edited

Loading

grahamu commented May 12, 2016 •

edited

Loading

brosner May 12, 2016

grahamu May 13, 2016

coveralls commented May 13, 2016 •

edited

Loading

Refactoring validate() to handle resource data collections #5

Refactoring validate() to handle resource data collections #5

Conversation

grahamu commented May 7, 2016

grahamu commented May 7, 2016

grahamu commented May 9, 2016

coveralls commented May 11, 2016 • edited Loading

coveralls commented May 12, 2016 • edited Loading

grahamu commented May 12, 2016 • edited Loading

brosner May 12, 2016

Choose a reason for hiding this comment

grahamu May 13, 2016

Choose a reason for hiding this comment

coveralls commented May 13, 2016 • edited Loading

coveralls commented May 11, 2016 •

edited

Loading

coveralls commented May 12, 2016 •

edited

Loading

grahamu commented May 12, 2016 •

edited

Loading

coveralls commented May 13, 2016 •

edited

Loading