Use CBV #34
Merged
Use CBV #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| from django.http import HttpResponse, HttpResponseForbidden | ||
| from django.shortcuts import get_object_or_404, redirect | ||
| from django.contrib.auth.decorators import login_required |
There was a problem hiding this comment.
We should use DUA's login_required decorator if DUA is installed and fall back to contrib auth's version. However, since we are doing CBVs, we should use DUA's account.mixins.LoginRequiredMixin if available, otherwise fall back.
|
Since DUA LoginRequiredMixins with fallback has been added i think it should also close issue : Closes #26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace current view with a CBV
Django-brace has been used to handle ajax in view
Fixes #33