-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large aggregation #192
Large aggregation #192
Commits on Jan 11, 2022
-
Squashed commit of the following:
commit 8564eb0 Merge: f6ef62c 07cc7d8 Author: Kendell Clement <k.clement.dev@gmail.com> Date: Tue Jan 11 16:20:15 2022 -0500 Merge branch 'indel-alignment-fix' of https://github.com/edilytics/CRISPResso2 into indel-alignment-fix commit 07cc7d8 Author: Cole Lyman <cole@colelyman.com> Date: Fri Dec 10 15:29:59 2021 -0700 Fix bug in `find_indels_substitutions` This bug occurred when there was a deletion at the end of a sequence, and was thus not properly accounted for. commit f6ef62c Author: Cole Lyman <cole@colelyman.com> Date: Fri Dec 10 15:29:59 2021 -0700 Fix bug in `find_indels_substitutions` This bug occurred when there was a deletion at the end of a sequence, and was thus not properly accounted for. commit 7212f87 Author: Cole Lyman <cole@colelyman.com> Date: Fri Dec 10 15:26:17 2021 -0700 Add a unit test for `find_indels_substitutions` This unit test checks for deletions at the end of a sequence, which are inherently outside of the include_indx_set window. commit d50b4e9 Author: Cole Lyman <cole@colelyman.com> Date: Fri Dec 10 15:03:22 2021 -0700 Fix a bug in `find_indels_substitutions` The bug that this commit fixes is when an insertion occurs at the edge of the include indexes. The trouble with this earlier was that it was using the `idx` to calculate the size of the insertion, but the `idx` wasn't being incremented anymore because it was outside of the include window. commit 4db066f Author: Cole Lyman <cole@colelyman.com> Date: Fri Dec 10 15:01:39 2021 -0700 Add test case for `find_indels_substitutions` This test case is extracted from the CRISPRessoBatch integration test and provides an example where there is an insertion at the edge of the include index. commit 3b3a741 Author: Cole Lyman <cole@colelyman.com> Date: Fri Dec 10 11:37:07 2021 -0700 Fix bug in CRISPRessoCompare where sample names were not properly set This was a place where it was (partially) missed during the crispresso2_info object refactoring. commit e9f5eff Author: Cole Lyman <cole@colelyman.com> Date: Fri Dec 10 15:26:17 2021 -0700 Add a unit test for `find_indels_substitutions` This unit test checks for deletions at the end of a sequence, which are inherently outside of the include_indx_set window. commit d4d45a9 Author: Cole Lyman <cole@colelyman.com> Date: Fri Dec 10 15:03:22 2021 -0700 Fix a bug in `find_indels_substitutions` The bug that this commit fixes is when an insertion occurs at the edge of the include indexes. The trouble with this earlier was that it was using the `idx` to calculate the size of the insertion, but the `idx` wasn't being incremented anymore because it was outside of the include window. commit 13f00bb Author: Cole Lyman <cole@colelyman.com> Date: Fri Dec 10 15:01:39 2021 -0700 Add test case for `find_indels_substitutions` This test case is extracted from the CRISPRessoBatch integration test and provides an example where there is an insertion at the edge of the include index. commit 659ae34 Author: Cole Lyman <cole@colelyman.com> Date: Fri Dec 10 11:37:07 2021 -0700 Fix bug in CRISPRessoCompare where sample names were not properly set This was a place where it was (partially) missed during the crispresso2_info object refactoring.
Configuration menu - View commit details
-
Copy full SHA for a7ffd46 - Browse repository at this point
Copy the full SHA a7ffd46View commit details
Commits on Jan 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ddbd39f - Browse repository at this point
Copy the full SHA ddbd39fView commit details
Commits on Jan 23, 2022
-
Add parameter
--suppress_batch_summary_plots
If many runs are run at the same time, batch summary plots may fail because they are too large for matplotlib. This parameter `--suppress_batch_summary_plots` allows individual runs to be plotted, but suppresses batch summary plots that may otherwise be too big.
Configuration menu - View commit details
-
Copy full SHA for a7cde12 - Browse repository at this point
Copy the full SHA a7cde12View commit details -
Configuration menu - View commit details
-
Copy full SHA for c150468 - Browse repository at this point
Copy the full SHA c150468View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55c2e9b - Browse repository at this point
Copy the full SHA 55c2e9bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1316d30 - Browse repository at this point
Copy the full SHA 1316d30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e9b50b - Browse repository at this point
Copy the full SHA 2e9b50bView commit details
Commits on Jan 24, 2022
-
Add --max_samples_per_summary_plot to CRISPRessoAggregate
Parameterize the max number of samples to plot on each page of reports. Additional PDFs will be created with this number of samples on them.
Configuration menu - View commit details
-
Copy full SHA for 6d5bc83 - Browse repository at this point
Copy the full SHA 6d5bc83View commit details
Commits on Jan 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ef67027 - Browse repository at this point
Copy the full SHA ef67027View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ffdff7 - Browse repository at this point
Copy the full SHA 2ffdff7View commit details -
Add plotting of heatmaps to CRISPRessoAggregateCORE to summarize modi…
…fication types These heatmaps are interactive (zoomable and panable) and show for each sample the percentage of insertions, substitutions, and deletions.
Configuration menu - View commit details
-
Copy full SHA for 06e05db - Browse repository at this point
Copy the full SHA 06e05dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for bab6e51 - Browse repository at this point
Copy the full SHA bab6e51View commit details
Commits on Jan 28, 2022
-
This is mainly so that we can use the fullscreen modal functionality in this version.
Configuration menu - View commit details
-
Copy full SHA for 7829387 - Browse repository at this point
Copy the full SHA 7829387View commit details
Commits on Jan 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9da1403 - Browse repository at this point
Copy the full SHA 9da1403View commit details
Commits on Mar 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bbb7d6f - Browse repository at this point
Copy the full SHA bbb7d6fView commit details -
Fix bug where plots were not filling up entire modal.
I have tried countless different ways for this to work, and this is the best that I can come up with. After the modal is opened it triggers the plot to resize, and then for some reason you need to trigger the resize event. I think this is because a `div` changing size won't actually trigger the resizing of the plot (and neither will just calling `Plotly.Plots.resize`...?!).
Configuration menu - View commit details
-
Copy full SHA for 769f58d - Browse repository at this point
Copy the full SHA 769f58dView commit details
Commits on Mar 16, 2022
-
Update the axis labels and add autosize to plotly heatmaps
I'm pretty sure the autosize doesn't do anything, but it is there for good measure.
Configuration menu - View commit details
-
Copy full SHA for 802bb1f - Browse repository at this point
Copy the full SHA 802bb1fView commit details -
Abandon attempts to make plots fullscreen
This includes removing the Bootstrap modal (two out of the three plots would resize properly and I couldn't figure out a way to have the plot displayed outside of the modal). I have left in some javascript to make the plot fullscreen, but I couldn't get the formatting quite right and the plot wasn't much bigger in the fullscreen version because there was a ton of space between the plot and the heatmap. If some brave soul would like to tackle it, feel free!
Configuration menu - View commit details
-
Copy full SHA for 91fa0ad - Browse repository at this point
Copy the full SHA 91fa0adView commit details
Commits on Mar 18, 2022
-
Rename and refactor how plot data is passed around
I have consolidated how the plot data is passed around, so that now you can pass in only one dict with all of the information instead of 4 or 5 separate parameters. I also renamed the `heatmap_plot_*` to `allele_modification_heatmap_*`.
Configuration menu - View commit details
-
Copy full SHA for ec6e570 - Browse repository at this point
Copy the full SHA ec6e570View commit details
Commits on Mar 22, 2022
-
Implement the line plot version of the modification percentages
This also includes correctly resizing the plot when the line plot tab is selected!
Configuration menu - View commit details
-
Copy full SHA for e8370ec - Browse repository at this point
Copy the full SHA e8370ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82f5d55 - Browse repository at this point
Copy the full SHA 82f5d55View commit details -
Remove extra assignments of
this_number_samples
and suppress plotThe plot that is suppressed is the large nucleotide quilt when there is a large number of samples. Is it okay to suppress this plot @kclem?
2Configuration menu - View commit details
-
Copy full SHA for e076330 - Browse repository at this point
Copy the full SHA e076330View commit details
Commits on Mar 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 05c5bbd - Browse repository at this point
Copy the full SHA 05c5bbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbe560f - Browse repository at this point
Copy the full SHA cbe560fView commit details
Commits on Mar 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for af4ab6e - Browse repository at this point
Copy the full SHA af4ab6eView commit details -
Add parameter
--suppress_batch_summary_plots
If many runs are run at the same time, batch summary plots may fail because they are too large for matplotlib. This parameter `--suppress_batch_summary_plots` allows individual runs to be plotted, but suppresses batch summary plots that may otherwise be too big.
Configuration menu - View commit details
-
Copy full SHA for b7245da - Browse repository at this point
Copy the full SHA b7245daView commit details -
Configuration menu - View commit details
-
Copy full SHA for c5ff5b4 - Browse repository at this point
Copy the full SHA c5ff5b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 70c22c4 - Browse repository at this point
Copy the full SHA 70c22c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 87839e7 - Browse repository at this point
Copy the full SHA 87839e7View commit details -
Update CRISPRessoAggregateCORE.py
Remove max sample limit for plotting
Configuration menu - View commit details
-
Copy full SHA for e41d639 - Browse repository at this point
Copy the full SHA e41d639View commit details -
Add --max_samples_per_summary_plot to CRISPRessoAggregate
Parameterize the max number of samples to plot on each page of reports. Additional PDFs will be created with this number of samples on them.
Configuration menu - View commit details
-
Copy full SHA for f86b10f - Browse repository at this point
Copy the full SHA f86b10fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed6a038 - Browse repository at this point
Copy the full SHA ed6a038View commit details -
Configuration menu - View commit details
-
Copy full SHA for 47a6bc0 - Browse repository at this point
Copy the full SHA 47a6bc0View commit details -
Add plotting of heatmaps to CRISPRessoAggregateCORE to summarize modi…
…fication types These heatmaps are interactive (zoomable and panable) and show for each sample the percentage of insertions, substitutions, and deletions.
Configuration menu - View commit details
-
Copy full SHA for b1951a6 - Browse repository at this point
Copy the full SHA b1951a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 164299d - Browse repository at this point
Copy the full SHA 164299dView commit details -
This is mainly so that we can use the fullscreen modal functionality in this version.
Configuration menu - View commit details
-
Copy full SHA for 13c03f8 - Browse repository at this point
Copy the full SHA 13c03f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45e4ccf - Browse repository at this point
Copy the full SHA 45e4ccfView commit details -
Fix bug where plots were not filling up entire modal.
I have tried countless different ways for this to work, and this is the best that I can come up with. After the modal is opened it triggers the plot to resize, and then for some reason you need to trigger the resize event. I think this is because a `div` changing size won't actually trigger the resizing of the plot (and neither will just calling `Plotly.Plots.resize`...?!).
Configuration menu - View commit details
-
Copy full SHA for b5897f9 - Browse repository at this point
Copy the full SHA b5897f9View commit details -
Update the axis labels and add autosize to plotly heatmaps
I'm pretty sure the autosize doesn't do anything, but it is there for good measure.
Configuration menu - View commit details
-
Copy full SHA for 62f4e38 - Browse repository at this point
Copy the full SHA 62f4e38View commit details -
Abandon attempts to make plots fullscreen
This includes removing the Bootstrap modal (two out of the three plots would resize properly and I couldn't figure out a way to have the plot displayed outside of the modal). I have left in some javascript to make the plot fullscreen, but I couldn't get the formatting quite right and the plot wasn't much bigger in the fullscreen version because there was a ton of space between the plot and the heatmap. If some brave soul would like to tackle it, feel free!
Configuration menu - View commit details
-
Copy full SHA for ff1305a - Browse repository at this point
Copy the full SHA ff1305aView commit details -
Rename and refactor how plot data is passed around
I have consolidated how the plot data is passed around, so that now you can pass in only one dict with all of the information instead of 4 or 5 separate parameters. I also renamed the `heatmap_plot_*` to `allele_modification_heatmap_*`.
Configuration menu - View commit details
-
Copy full SHA for f0d424d - Browse repository at this point
Copy the full SHA f0d424dView commit details -
Implement the line plot version of the modification percentages
This also includes correctly resizing the plot when the line plot tab is selected!
Configuration menu - View commit details
-
Copy full SHA for 7653f67 - Browse repository at this point
Copy the full SHA 7653f67View commit details -
Configuration menu - View commit details
-
Copy full SHA for 077a60c - Browse repository at this point
Copy the full SHA 077a60cView commit details -
Remove extra assignments of
this_number_samples
and suppress plotThe plot that is suppressed is the large nucleotide quilt when there is a large number of samples. Is it okay to suppress this plot @kclem?
Configuration menu - View commit details
-
Copy full SHA for e32b202 - Browse repository at this point
Copy the full SHA e32b202View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8c1a8c - Browse repository at this point
Copy the full SHA b8c1a8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e514ccf - Browse repository at this point
Copy the full SHA e514ccfView commit details
Commits on Mar 27, 2022
-
Merge branch 'largeAggregation' of https://github.com/edilytics/CRISP…
…Resso2 into largeAggregation
Configuration menu - View commit details
-
Copy full SHA for 862e803 - Browse repository at this point
Copy the full SHA 862e803View commit details -
Configuration menu - View commit details
-
Copy full SHA for dcadcff - Browse repository at this point
Copy the full SHA dcadcffView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0220ea4 - Browse repository at this point
Copy the full SHA 0220ea4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4380407 - Browse repository at this point
Copy the full SHA 4380407View commit details
Commits on Mar 28, 2022
-
Fill in default (empty) values to allele modification plots
When not running CRISPRessoAggregate, default values for the `allele_modification_heatmap_plot` and `allele_modification_lin_plot` dictionaries will be set so that the template can be properly rendered.
Configuration menu - View commit details
-
Copy full SHA for 13c56ee - Browse repository at this point
Copy the full SHA 13c56eeView commit details
Commits on Mar 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4b2bdcd - Browse repository at this point
Copy the full SHA 4b2bdcdView commit details
Commits on Apr 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f69250f - Browse repository at this point
Copy the full SHA f69250fView commit details
Commits on May 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0f1beda - Browse repository at this point
Copy the full SHA 0f1bedaView commit details -
Configuration menu - View commit details
-
Copy full SHA for e96e3df - Browse repository at this point
Copy the full SHA e96e3dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 095ce13 - Browse repository at this point
Copy the full SHA 095ce13View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5f9ec0 - Browse repository at this point
Copy the full SHA b5f9ec0View commit details -
Coerce ints in batch file checking (pinellolab#200)
* Batch type coerce and r2 file check * Revert "Batch type coerce and r2 file check" This reverts commit f917366. * Coerce int values
Configuration menu - View commit details
-
Copy full SHA for 0002ebb - Browse repository at this point
Copy the full SHA 0002ebbView commit details -
Handle multiple qwcs in batch mode
If multiple qwcs were provided in batch mode, a parsing error would occur. This fixes this bug.
Configuration menu - View commit details
-
Copy full SHA for 1a2d9c1 - Browse repository at this point
Copy the full SHA 1a2d9c1View commit details -
Fix bug from old pandas for int cols
Evidently old pandas versions throw an error if a column doesn't exist. This checks to see if the column exists before the values are set.
Configuration menu - View commit details
-
Copy full SHA for ded680c - Browse repository at this point
Copy the full SHA ded680cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e812ed - Browse repository at this point
Copy the full SHA 4e812edView commit details
Commits on May 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3b21f39 - Browse repository at this point
Copy the full SHA 3b21f39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 894a266 - Browse repository at this point
Copy the full SHA 894a266View commit details -
Configuration menu - View commit details
-
Copy full SHA for dffcd21 - Browse repository at this point
Copy the full SHA dffcd21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 114562c - Browse repository at this point
Copy the full SHA 114562cView commit details -
Make
--suppress_batch_summary_plots
store trueAlso, only open and shutdown the process pool when necessary.
Configuration menu - View commit details
-
Copy full SHA for 1379c07 - Browse repository at this point
Copy the full SHA 1379c07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4558350 - Browse repository at this point
Copy the full SHA 4558350View commit details