Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large aggregation #192

Merged
merged 67 commits into from
May 4, 2022
Merged

Large aggregation #192

merged 67 commits into from
May 4, 2022

Commits on Jan 11, 2022

  1. Squashed commit of the following:

    commit 8564eb0
    Merge: f6ef62c 07cc7d8
    Author: Kendell Clement <k.clement.dev@gmail.com>
    Date:   Tue Jan 11 16:20:15 2022 -0500
    
        Merge branch 'indel-alignment-fix' of https://github.com/edilytics/CRISPResso2 into indel-alignment-fix
    
    commit 07cc7d8
    Author: Cole Lyman <cole@colelyman.com>
    Date:   Fri Dec 10 15:29:59 2021 -0700
    
        Fix bug in `find_indels_substitutions`
    
        This bug occurred when there was a deletion at the end of a sequence, and was
        thus not properly accounted for.
    
    commit f6ef62c
    Author: Cole Lyman <cole@colelyman.com>
    Date:   Fri Dec 10 15:29:59 2021 -0700
    
        Fix bug in `find_indels_substitutions`
    
        This bug occurred when there was a deletion at the end of a sequence, and was
        thus not properly accounted for.
    
    commit 7212f87
    Author: Cole Lyman <cole@colelyman.com>
    Date:   Fri Dec 10 15:26:17 2021 -0700
    
        Add a unit test for `find_indels_substitutions`
    
        This unit test checks for deletions at the end of a sequence, which are
        inherently outside of the include_indx_set window.
    
    commit d50b4e9
    Author: Cole Lyman <cole@colelyman.com>
    Date:   Fri Dec 10 15:03:22 2021 -0700
    
        Fix a bug in `find_indels_substitutions`
    
        The bug that this commit fixes is when an insertion occurs at the edge of the
        include indexes. The trouble with this earlier was that it was using the `idx`
        to calculate the size of the insertion, but the `idx` wasn't being incremented
        anymore because it was outside of the include window.
    
    commit 4db066f
    Author: Cole Lyman <cole@colelyman.com>
    Date:   Fri Dec 10 15:01:39 2021 -0700
    
        Add test case for `find_indels_substitutions`
    
        This test case is extracted from the CRISPRessoBatch integration test and
        provides an example where there is an insertion at the edge of the include
        index.
    
    commit 3b3a741
    Author: Cole Lyman <cole@colelyman.com>
    Date:   Fri Dec 10 11:37:07 2021 -0700
    
        Fix bug in CRISPRessoCompare where sample names were not properly set
    
        This was a place where it was (partially) missed during the crispresso2_info
        object refactoring.
    
    commit e9f5eff
    Author: Cole Lyman <cole@colelyman.com>
    Date:   Fri Dec 10 15:26:17 2021 -0700
    
        Add a unit test for `find_indels_substitutions`
    
        This unit test checks for deletions at the end of a sequence, which are
        inherently outside of the include_indx_set window.
    
    commit d4d45a9
    Author: Cole Lyman <cole@colelyman.com>
    Date:   Fri Dec 10 15:03:22 2021 -0700
    
        Fix a bug in `find_indels_substitutions`
    
        The bug that this commit fixes is when an insertion occurs at the edge of the
        include indexes. The trouble with this earlier was that it was using the `idx`
        to calculate the size of the insertion, but the `idx` wasn't being incremented
        anymore because it was outside of the include window.
    
    commit 13f00bb
    Author: Cole Lyman <cole@colelyman.com>
    Date:   Fri Dec 10 15:01:39 2021 -0700
    
        Add test case for `find_indels_substitutions`
    
        This test case is extracted from the CRISPRessoBatch integration test and
        provides an example where there is an insertion at the edge of the include
        index.
    
    commit 659ae34
    Author: Cole Lyman <cole@colelyman.com>
    Date:   Fri Dec 10 11:37:07 2021 -0700
    
        Fix bug in CRISPRessoCompare where sample names were not properly set
    
        This was a place where it was (partially) missed during the crispresso2_info
        object refactoring.
    kclem committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    a7ffd46 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Configuration menu
    Copy the full SHA
    ddbd39f View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2022

  1. Add parameter --suppress_batch_summary_plots

    If many runs are run at the same time, batch summary plots may fail because they are too large for matplotlib. This parameter `--suppress_batch_summary_plots` allows individual runs to be plotted, but suppresses batch summary plots that may otherwise be too big.
    kclem committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    a7cde12 View commit details
    Browse the repository at this point in the history
  2. Pep formatting cleanup

    kclem committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    c150468 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    55c2e9b View commit details
    Browse the repository at this point in the history
  4. Aggregate plots are paginated

    kclem committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    1316d30 View commit details
    Browse the repository at this point in the history
  5. Update CRISPRessoAggregateCORE.py

    Remove max sample limit for plotting
    kclem committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    2e9b50b View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Add --max_samples_per_summary_plot to CRISPRessoAggregate

    Parameterize the max number of samples to plot on each page of reports. Additional PDFs will be created with this number of samples on them.
    kclem committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    6d5bc83 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Configuration menu
    Copy the full SHA
    ef67027 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2ffdff7 View commit details
    Browse the repository at this point in the history
  3. Add plotting of heatmaps to CRISPRessoAggregateCORE to summarize modi…

    …fication types
    
    These heatmaps are interactive (zoomable and panable) and show for each sample
    the percentage of insertions, substitutions, and deletions.
    Colelyman committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    06e05db View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bab6e51 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. Update Bootstrap to 5.1.3

    This is mainly so that we can use the fullscreen modal functionality in this version.
    Colelyman committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    7829387 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2022

  1. Configuration menu
    Copy the full SHA
    9da1403 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2022

  1. Configuration menu
    Copy the full SHA
    bbb7d6f View commit details
    Browse the repository at this point in the history
  2. Fix bug where plots were not filling up entire modal.

    I have tried countless different ways for this to work, and this is the best
    that I can come up with. After the modal is opened it triggers the plot to
    resize, and then for some reason you need to trigger the resize event. I think
    this is because a `div` changing size won't actually trigger the resizing of the
    plot (and neither will just calling `Plotly.Plots.resize`...?!).
    Colelyman committed Mar 15, 2022
    Configuration menu
    Copy the full SHA
    769f58d View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2022

  1. Update the axis labels and add autosize to plotly heatmaps

    I'm pretty sure the autosize doesn't do anything, but it is there for good
    measure.
    Colelyman committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    802bb1f View commit details
    Browse the repository at this point in the history
  2. Abandon attempts to make plots fullscreen

    This includes removing the Bootstrap modal (two out of the three plots would
    resize properly and I couldn't figure out a way to have the plot displayed
    outside of the modal). I have left in some javascript to make the plot
    fullscreen, but I couldn't get the formatting quite right and the plot wasn't
    much bigger in the fullscreen version because there was a ton of space between
    the plot and the heatmap. If some brave soul would like to tackle it, feel free!
    Colelyman committed Mar 16, 2022
    Configuration menu
    Copy the full SHA
    91fa0ad View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2022

  1. Rename and refactor how plot data is passed around

    I have consolidated how the plot data is passed around, so that now you can pass
    in only one dict with all of the information instead of 4 or 5 separate
    parameters. I also renamed the `heatmap_plot_*` to
    `allele_modification_heatmap_*`.
    Colelyman committed Mar 18, 2022
    Configuration menu
    Copy the full SHA
    ec6e570 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2022

  1. Implement the line plot version of the modification percentages

    This also includes correctly resizing the plot when the line plot tab is
    selected!
    Colelyman committed Mar 22, 2022
    Configuration menu
    Copy the full SHA
    e8370ec View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82f5d55 View commit details
    Browse the repository at this point in the history
  3. Remove extra assignments of this_number_samples and suppress plot

    The plot that is suppressed is the large nucleotide quilt when there is a large
    number of samples. Is it okay to suppress this plot @kclem?
    Colelyman committed Mar 22, 2022
    2 Configuration menu
    Copy the full SHA
    e076330 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2022

  1. Configuration menu
    Copy the full SHA
    05c5bbd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cbe560f View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2022

  1. Configuration menu
    Copy the full SHA
    af4ab6e View commit details
    Browse the repository at this point in the history
  2. Add parameter --suppress_batch_summary_plots

    If many runs are run at the same time, batch summary plots may fail because they are too large for matplotlib. This parameter `--suppress_batch_summary_plots` allows individual runs to be plotted, but suppresses batch summary plots that may otherwise be too big.
    kclem authored and Colelyman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    b7245da View commit details
    Browse the repository at this point in the history
  3. Pep formatting cleanup

    kclem authored and Colelyman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    c5ff5b4 View commit details
    Browse the repository at this point in the history
  4. Add summary nucleotide plots to aggregate

    kclem authored and Colelyman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    70c22c4 View commit details
    Browse the repository at this point in the history
  5. Aggregate plots are paginated

    kclem authored and Colelyman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    87839e7 View commit details
    Browse the repository at this point in the history
  6. Update CRISPRessoAggregateCORE.py

    Remove max sample limit for plotting
    kclem authored and Colelyman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    e41d639 View commit details
    Browse the repository at this point in the history
  7. Add --max_samples_per_summary_plot to CRISPRessoAggregate

    Parameterize the max number of samples to plot on each page of reports. Additional PDFs will be created with this number of samples on them.
    kclem authored and Colelyman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    f86b10f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ed6a038 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    47a6bc0 View commit details
    Browse the repository at this point in the history
  10. Add plotting of heatmaps to CRISPRessoAggregateCORE to summarize modi…

    …fication types
    
    These heatmaps are interactive (zoomable and panable) and show for each sample
    the percentage of insertions, substitutions, and deletions.
    Colelyman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    b1951a6 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    164299d View commit details
    Browse the repository at this point in the history
  12. Update Bootstrap to 5.1.3

    This is mainly so that we can use the fullscreen modal functionality in this version.
    Colelyman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    13c03f8 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    45e4ccf View commit details
    Browse the repository at this point in the history
  14. Fix bug where plots were not filling up entire modal.

    I have tried countless different ways for this to work, and this is the best
    that I can come up with. After the modal is opened it triggers the plot to
    resize, and then for some reason you need to trigger the resize event. I think
    this is because a `div` changing size won't actually trigger the resizing of the
    plot (and neither will just calling `Plotly.Plots.resize`...?!).
    Colelyman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    b5897f9 View commit details
    Browse the repository at this point in the history
  15. Update the axis labels and add autosize to plotly heatmaps

    I'm pretty sure the autosize doesn't do anything, but it is there for good
    measure.
    Colelyman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    62f4e38 View commit details
    Browse the repository at this point in the history
  16. Abandon attempts to make plots fullscreen

    This includes removing the Bootstrap modal (two out of the three plots would
    resize properly and I couldn't figure out a way to have the plot displayed
    outside of the modal). I have left in some javascript to make the plot
    fullscreen, but I couldn't get the formatting quite right and the plot wasn't
    much bigger in the fullscreen version because there was a ton of space between
    the plot and the heatmap. If some brave soul would like to tackle it, feel free!
    Colelyman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    ff1305a View commit details
    Browse the repository at this point in the history
  17. Rename and refactor how plot data is passed around

    I have consolidated how the plot data is passed around, so that now you can pass
    in only one dict with all of the information instead of 4 or 5 separate
    parameters. I also renamed the `heatmap_plot_*` to
    `allele_modification_heatmap_*`.
    Colelyman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    f0d424d View commit details
    Browse the repository at this point in the history
  18. Implement the line plot version of the modification percentages

    This also includes correctly resizing the plot when the line plot tab is
    selected!
    Colelyman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    7653f67 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    077a60c View commit details
    Browse the repository at this point in the history
  20. Remove extra assignments of this_number_samples and suppress plot

    The plot that is suppressed is the large nucleotide quilt when there is a large
    number of samples. Is it okay to suppress this plot @kclem?
    Colelyman committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    e32b202 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    b8c1a8c View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    e514ccf View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2022

  1. Configuration menu
    Copy the full SHA
    862e803 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dcadcff View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0220ea4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4380407 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2022

  1. Fill in default (empty) values to allele modification plots

    When not running CRISPRessoAggregate, default values for the
    `allele_modification_heatmap_plot` and `allele_modification_lin_plot`
    dictionaries will be set so that the template can be properly rendered.
    Colelyman committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    13c56ee View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. Configuration menu
    Copy the full SHA
    4b2bdcd View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. Configuration menu
    Copy the full SHA
    f69250f View commit details
    Browse the repository at this point in the history

Commits on May 2, 2022

  1. Configuration menu
    Copy the full SHA
    0f1beda View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e96e3df View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    095ce13 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b5f9ec0 View commit details
    Browse the repository at this point in the history
  5. Coerce ints in batch file checking (pinellolab#200)

    * Batch type coerce and r2 file check
    
    * Revert "Batch type coerce and r2 file check"
    
    This reverts commit f917366.
    
    * Coerce int values
    Snicker7 authored and Colelyman committed May 2, 2022
    Configuration menu
    Copy the full SHA
    0002ebb View commit details
    Browse the repository at this point in the history
  6. Handle multiple qwcs in batch mode

    If multiple qwcs were provided in batch mode, a parsing error would occur. This fixes this bug.
    kclem authored and Colelyman committed May 2, 2022
    Configuration menu
    Copy the full SHA
    1a2d9c1 View commit details
    Browse the repository at this point in the history
  7. Fix bug from old pandas for int cols

    Evidently old pandas versions throw an error if a column doesn't exist. This checks to see if the column exists before the values are set.
    kclem authored and Colelyman committed May 2, 2022
    Configuration menu
    Copy the full SHA
    ded680c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4e812ed View commit details
    Browse the repository at this point in the history

Commits on May 3, 2022

  1. Configuration menu
    Copy the full SHA
    3b21f39 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    894a266 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dffcd21 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    114562c View commit details
    Browse the repository at this point in the history
  5. Make --suppress_batch_summary_plots store true

    Also, only open and shutdown the process pool when necessary.
    Colelyman committed May 3, 2022
    Configuration menu
    Copy the full SHA
    1379c07 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4558350 View commit details
    Browse the repository at this point in the history