-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes torch dataloader from load_data, adds initial tests to dataloading #156
Conversation
ssenan
commented
Jun 23, 2023
- Resolve torch dataloader tied to preprocessing function #155
- Moves the torch dataloader instantiation to train_util class
- Adds tests to SequenceDataset class that is used to instantiate dataloader
- Adds hatch run test to build workflow
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
=========================================
+ Coverage 2.73% 11.39% +8.66%
=========================================
Files 12 13 +1
Lines 805 825 +20
Branches 89 89
=========================================
+ Hits 22 94 +72
+ Misses 783 730 -53
- Partials 0 1 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps the tests would be run twice with the suggested change to the build workflow.
.github/workflows/build.yml
Outdated
@@ -29,6 +29,7 @@ jobs: | |||
hatch run lint-check | |||
- name: Test | |||
run: | | |||
hatch run test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the two adjacent lines here are the same,
Line 141 in a55002d
test-cov-xml = "pytest -rA --cov-report=xml" |
this should be redundant (i.e. the new functionality would essentially run the tests twice).