Objs #93
Merged
Objs #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joajfreitas
force-pushed
the
objs
branch
6 times, most recently
from
8321360
to
06a92b0
Compare
pineman
approved these changes
Jul 29, 2024
fpt/src/ppu.rs
Outdated
| @@ -78,6 +83,10 @@ impl Ppu { | |||
| fn oam_scan(&mut self) { | |||
| if self.dots_this_frame % 456 == (80 - 1) { | |||
| self.tilemap = self.bus.with_vram(VRamContents::load); | |||
| let oam = self.bus.copy_range(map::OAM); | |||
| self.sprites = (0..40) | |||
| .map(|sprite_index| Sprite::load(&oam[sprite_index * 4..(sprite_index * 4 + 4)])) | |||
There was a problem hiding this comment.
can you explain the magic numbers here? the * 4 and + 4.
the ppu already has lots of magic numbers I introduced that I dislike 😅
fpt/src/ppu.rs
Outdated
| let mut pixel = tile.get_pixel(yy % 8, xx % 8); | ||
|
|
||
| for sprite in self.sprites.iter() { | ||
| let sprite_x: i32 = sprite.x as i32 - 8; |
There was a problem hiding this comment.
could we remove the repeated as i32 casts somehow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #67