Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev-Build] support building with FIPS feature #2606

Closed
17 tasks done
wuhuizuo opened this issue Nov 10, 2023 · 7 comments
Closed
17 tasks done

[Dev-Build] support building with FIPS feature #2606

wuhuizuo opened this issue Nov 10, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@wuhuizuo
Copy link
Collaborator

wuhuizuo commented Nov 10, 2023

Requirements

Support building binaries and images for these components:

  • TiDB pingcap/tidb
  • TiKV tikv/tikv
  • PD tikv/pd
  • TiCDC pingcap/tiflow
  • BR pingcap/tidb
  • Dashboard pingcap/tidb-dashboard
  • Operator pingcap/tidb-operator
  • Ng-monitoring pingcap/ng-monitoring

Required informations

Go version

go 1.19+ (v6.5.x: 1.19, trunk branches: 1.21)

How to build

  • TiDB pingcap/tidb
  • TiKV tikv/tikv
  • PD tikv/pd
  • TiCDC pingcap/tiflow
  • BR pingcap/tidb
  • Dashboard pingcap/tidb-dashboard
  • Operator pingcap/tidb-operator
  • Ng-monitoring pingcap/ng-monitoring

Which one is need to change the runtime base images?

@wuhuizuo wuhuizuo added the enhancement New feature or request label Nov 10, 2023
@wuhuizuo wuhuizuo added this to the 2023-11 milestone Nov 10, 2023
@overvenus
Copy link
Contributor

To build such binary, we can add an env variable "ENABLE_FIPS=1".

E.g.,

PD: make build -> ENABLE_FIPS=1 make build
TiDB: make server -> ENABLE_FIPS=1 make server
TiKV: ROCKSDB_SYS_STATIC=1 make dist_release -> ENABLE_FIPS=1 ROCKSDB_SYS_STATIC=1 make dist_release

@jayl1e
Copy link
Contributor

jayl1e commented Nov 13, 2023

Is it enough, do we need to change buider image and product image?

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Nov 15, 2023

Implementation of building logic:

@overvenus
Copy link
Contributor

We need to support one more project:

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Dec 4, 2023

After communicating with @csuzhangxc(the owner of tidb-operator), a consensus was reached. Considering the release frequency of the FIPS targets, tidb-operator does not need to be supported in nightly build. It can be supported in dev-build. When it is officially released, its product will be re-released with the official tag.

ti-chi-bot bot pushed a commit that referenced this issue Dec 11, 2023
relate to #2606.

Signed-off-by: purelind <purelind@gmail.com>
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Jan 5, 2024

complete tidb-dashboard in #2721

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Jan 5, 2024

@wuhuizuo wuhuizuo closed this as completed Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

3 participants