Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

cmd: extend decode cmd to print any field #519

Merged
merged 4 commits into from
Sep 30, 2020

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Extend decode cmd to print any field

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • No release note (it's a hidden debug command.)

Signed-off-by: Neil Shen <overvenus@gmail.com>
Comment on lines +99 to +100
// cmd.PrintErr prints to stderr, but PrintErrf prints to stdout.
cmd.PrintErr(fmt.Sprintf("Detail BR log in %s \n", conf.File.Filename))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol a bug fix spf13/cobra#894 has been submitted but stay unmerged for over a year because some dependencies now relied on the bug (classic xkcd-1172 scenario)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bug becomes a feature 🤯

Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Sep 29, 2020
@YuJuncen
Copy link
Collaborator

LGTM

@ti-srebot ti-srebot removed the status/LGT1 LGTM1 label Sep 30, 2020
@ti-srebot ti-srebot added the status/LGT2 LGTM2 label Sep 30, 2020
@overvenus overvenus merged commit a2a7d22 into pingcap:master Sep 30, 2020
@overvenus overvenus deleted the extend-decode branch September 30, 2020 03:56
3pointer pushed a commit to 3pointer/br that referenced this pull request Oct 16, 2020
Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants