This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
cmd: extend decode cmd to print any field #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Shen <overvenus@gmail.com>
kennytm
reviewed
Sep 21, 2020
Comment on lines
+99
to
+100
| // cmd.PrintErr prints to stderr, but PrintErrf prints to stdout. | ||
| cmd.PrintErr(fmt.Sprintf("Detail BR log in %s \n", conf.File.Filename)) |
There was a problem hiding this comment.
lol a bug fix spf13/cobra#894 has been submitted but stay unmerged for over a year because some dependencies now relied on the bug (classic xkcd-1172 scenario)
There was a problem hiding this comment.
A bug becomes a feature 🤯
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
|
LGTM |
ti-srebot
approved these changes
Sep 30, 2020
3pointer
pushed a commit
to 3pointer/br
that referenced
this pull request
Oct 16, 2020
Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Extend decode cmd to print any field
Check List
Tests
Related changes
Release Note