-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vote ywqzzy as TiDB reviewer #763
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@wjhuang2016: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: tangenta <tangenta@126.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jackysp, tangenta, wjhuang2016 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: cannot checkout |
In response to a cherrypick label: cannot checkout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to make a '-1' vote for the following reason:
- The nominees has 9 commits for the last 1 year, although we do not have a 'required commit' number I still think it's better to promote a reviewer when he/she is more 'active' with more contributions.
- The nominees' contribution spreads in different areas: expression, executor, DDL, and tests... It's really hard for me to say that he's ready to review and approve the PR in a large codebase like TiDB.
As title description.