Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vote ywqzzy as TiDB reviewer #763

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Conversation

Benjamin2037
Copy link
Contributor

As title description.

@Benjamin2037 Benjamin2037 requested review from a team and zhangyangyu as code owners June 9, 2023 22:03
@ti-chi-bot ti-chi-bot bot requested a review from c4pt0r June 9, 2023 22:03
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 9, 2023
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 12, 2023
@jackysp jackysp changed the title vote ywq as TiDB reviewer vote ywqzzy as TiDB reviewer Jun 12, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 13, 2023

@wjhuang2016: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-authored-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 13, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 14, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jackysp, tangenta, wjhuang2016
Once this PR has been reviewed and has the lgtm label, please assign zhangyangyu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 14, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-12 17:30:36.659058295 +0000 UTC m=+20433.073662369: ☑️ agreed by jackysp.
  • 2023-06-13 18:47:57.761689706 +0000 UTC m=+111474.176293783: ✖️🔁 reset by Benjamin2037.
  • 2023-06-14 03:35:06.67628741 +0000 UTC m=+143103.090891489: ☑️ agreed by tangenta.

@tangenta tangenta merged commit 47012d3 into pingcap:master Jun 14, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout size/S: error checking out size/S: exit status 1. output: error: pathspec 'size/S' did not match any file(s) known to git

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout lgtm: error checking out lgtm: exit status 1. output: error: pathspec 'lgtm' did not match any file(s) known to git

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to make a '-1' vote for the following reason:

  1. The nominees has 9 commits for the last 1 year, although we do not have a 'required commit' number I still think it's better to promote a reviewer when he/she is more 'active' with more contributions.
  2. The nominees' contribution spreads in different areas: expression, executor, DDL, and tests... It's really hard for me to say that he's ready to review and approve the PR in a large codebase like TiDB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants