Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

votes: a vote for jiyfhust as the reviewer #772

Merged
merged 1 commit into from
Oct 23, 2023
Merged

votes: a vote for jiyfhust as the reviewer #772

merged 1 commit into from
Oct 23, 2023

Conversation

zimulala
Copy link
Contributor

As stated in the title.

@zimulala zimulala requested review from a team and zhangyangyu as code owners October 17, 2023 07:56
@ti-chi-bot ti-chi-bot bot requested a review from coocood October 17, 2023 07:56
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 17, 2023
@joccau
Copy link
Member

joccau commented Oct 17, 2023 •
edited
Loading

Why are some members from membership.json(

community/teams/tidb/membership.json

Line 4 in 0ae4dd6

"maintainers": [
) not in https://github.com/orgs/pingcap/teams/tidb-maintainers ?

@zhangyangyu
Copy link
Member

Why are some members from membership.json(

community/teams/tidb/membership.json

Line 4 in 0ae4dd6

"maintainers": [

) not in https://github.com/orgs/pingcap/teams/tidb-maintainers ?

Maybe removed previously but they do not accept the remediate invitation?

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 18, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-18 06:55:58.912070226 +0000 UTC m=+1812956.499180370: ☑️ agreed by disksing.

@zhangyangyu zhangyangyu requested a review from a team October 21, 2023 08:17
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: disksing, lance6716
Once this PR has been reviewed and has the lgtm label, please assign zhangyangyu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhangyangyu zhangyangyu merged commit 3da6de3 into pingcap:master Oct 23, 2023
1 of 2 checks passed
@zimulala zimulala deleted the zimuxia/vote-jiyfhust branch October 23, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@lance6716 lance6716 lance6716 approved these changes

@zhangyangyu zhangyangyu Awaiting requested review from zhangyangyu zhangyangyu is a code owner

@coocood coocood Awaiting requested review from coocood

Assignees
No one assigned
Labels
lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zimulala @joccau @zhangyangyu @lance6716 @disksing