Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

votes: add jiyfhust as a TiDB committer #785

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

zimulala
Copy link
Contributor

As stated in the title.

@zimulala zimulala requested a review from a team as a code owner April 17, 2024 11:07
@ti-chi-bot ti-chi-bot bot requested a review from cfzjywxk April 17, 2024 11:07
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 17, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 17, 2024
Copy link

ti-chi-bot bot commented Apr 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-17 11:52:48.594349626 +0000 UTC m=+425387.705396068: ☑️ agreed by lance6716.

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@zimulala
Copy link
Contributor Author

PTAL @zhangyangyu

Copy link

ti-chi-bot bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, lance6716, zhangyangyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 26, 2024
@zhangyangyu
Copy link
Member

/merge

@ti-chi-bot ti-chi-bot bot merged commit 38caa6f into pingcap:master Apr 26, 2024
1 of 2 checks passed
@zimulala zimulala deleted the zimuxia/vote-jiyfhust-2 branch April 28, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants