Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support dumping metrics by instance #470

Merged
merged 3 commits into from
May 21, 2024

Conversation

zyguan
Copy link
Contributor

@zyguan zyguan commented Jan 24, 2024

What problem does this PR solve?

For a large cluster, getSeriesNum may always fail due to quota limit. As a result, significant metrics like tidb_tikvclient_request_seconds and tikv_grpc_msg_duration_seconds are often missing, which blocks troubleshooting.

What is changed and how it works?

With this PR, if getSeriesNum failed, diag will fallback to by-instance dump mode, which get instance list first and call collectMetric by instance.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Signed-off-by: zyguan <zhongyangguan@gmail.com>
Signed-off-by: zyguan <zhongyangguan@gmail.com>
Signed-off-by: zyguan <zhongyangguan@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c0b393) 30.21% compared to head (913f819) 30.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #470   +/-   ##
=======================================
  Coverage   30.21%   30.21%           
=======================================
  Files          52       52           
  Lines        4416     4416           
=======================================
  Hits         1334     1334           
  Misses       2911     2911           
  Partials      171      171           
Flag Coverage Δ
unittests 30.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang kaaaaaaang merged commit 0bb750a into pingcap:master May 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants