support dumping metrics by instance #470
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
For a large cluster,
getSeriesNum
may always fail due to quota limit. As a result, significant metrics liketidb_tikvclient_request_seconds
andtikv_grpc_msg_duration_seconds
are often missing, which blocks troubleshooting.What is changed and how it works?
With this PR, if
getSeriesNum
failed, diag will fallback to by-instance dump mode, which get instance list first and callcollectMetric
by instance.Check List
Tests
Code changes
Side effects
Related changes