This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
*: fix cannot convert type: decimal.Decimal
(#375)
#376
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #375 to release-1.0
What problem does this PR solve?
in golang v1.13, the Decimal decompose interface is introduced, see:
in shopspring/decimal@75bb2cb, it implements the Decimal decompose interface.
when executing a statement with decimal type columns, a possible execution path is:
the code block
will cause the skip of the value fetching (convert
decimal.Decimal
tostring
) in https://github.com/go-sql-driver/mysql/blob/v1.4.1/statement.go#L146.then continue the execution flow:
another useful link golang/go#34315.
What is changed and how it works?
some methods can be used to fix this problem:
I chose the first one, and update shopspring/decimal to shopspring/decimal@b054a8d. (revert Decimal decompose interface implementation)
Check List
Tests
Related changes