Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

change timeouts-in-tidb.md to reflect gc is self-adaptive #74

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jinwhu
Copy link
Contributor

@jinwhu jinwhu commented Feb 14, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jackysp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -90,6 +90,20 @@ summary: 介绍如何设计数据库中的对象,如索引、字段类型等

- 当使用宽字段类型(如 Text、MediumBlob、MediumText)时,需注意读取并发度,以控制内存使用预防 OOM 。

关于 char 类型的特别说明:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

能否考虑把「CHAR:仅仅只有单个字符的字段使用 CHAR(1) 类型,例如性别字段。」这一行放在「关于 char 类型的特别说明:」正上方?

@@ -90,6 +90,20 @@ summary: 介绍如何设计数据库中的对象,如索引、字段类型等

- 当使用宽字段类型(如 Text、MediumBlob、MediumText)时,需注意读取并发度,以控制内存使用预防 OOM 。

关于 char 类型的特别说明:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

能否考虑把「CHAR:仅仅只有单个字符的字段使用 CHAR(1) 类型,例如性别字段。」这一行放在「关于 char 类型的特别说明:」正上方?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

每一行上下都需要空一行

关于 char 类型的特别说明:
1. 新框架 ( new_collations_enabled_on_first_bootstrap)

在 4.0 版本之前,TiDB 只提供了旧的排序规则框架,能够在语法上支持的绝大部分 MySQL 排序规则,但语义上所有的排序规则都当成二进制排序规则。4.0 版本中,TiDB 增加了新的排序规则框架用于在语义上支持不同的排序规则,保证字符串比较时严格遵循对应的排序规则。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缩进 8 个空格,这里多了一个空格。下同

@@ -90,6 +90,20 @@ summary: 介绍如何设计数据库中的对象,如索引、字段类型等

- 当使用宽字段类型(如 Text、MediumBlob、MediumText)时,需注意读取并发度,以控制内存使用预防 OOM 。

关于 char 类型的特别说明:
1. 新框架 ( new_collations_enabled_on_first_bootstrap)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否可以明确下是什么新框架?TiDB 排序规则新框架?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants