Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup: add document of tispark support in tiup cluster (#3963) #4136

Merged
merged 1 commit into from
Jul 31, 2020
Merged

tiup: add document of tispark support in tiup cluster (#3963) #4136

merged 1 commit into from
Jul 31, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #3963 to release-4.0

What is changed, added or deleted? (Required)

Add documentations of (experimental) support of TiSpark in TiUP Cluster. It should be merged after pingcap/tiup#531 is released.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

@AstroProfundis @ti-srebot
cherry pick pingcap#3963 to release-4.0
bc86086 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jul 31, 2020
Merged
5 tasks
@ti-srebot ti-srebot added priority/P1 The issue has P1 priority. size/medium Changes of a medium size. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. type/enhancement The issue or PR belongs to an enhancement. labels Jul 31, 2020
@ti-srebot
Copy link
Contributor Author

@AstroProfundis please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/docs-cn/invitations

lonng
lonng reviewed Jul 31, 2020
View reviewed changes
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor Author

@lonng,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

yikeke
yikeke approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 31, 2020
@yikeke yikeke merged commit 7a09901 into pingcap:release-4.0 Jul 31, 2020
@yikeke yikeke deleted the release-4.0-a87948272812 branch July 31, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonng lonng lonng left review comments

@yikeke yikeke yikeke approved these changes

@lucklove lucklove Awaiting requested review from lucklove

Assignees

@AstroProfundis AstroProfundis

Labels
priority/P1 The issue has P1 priority. size/medium Changes of a medium size. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-srebot @lonng @yikeke @AstroProfundis