ci: update the git diff command in the prevent deletion workflow to improve accuracy #2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on workflow Signed-off-by: Aolin <aolin.zhang@pingcap.com>
Oreoxmt
added
translation/done
ti-chi-bot
bot
added
the
size/XS
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Oreoxmt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
Merged
6 tasks
|
In response to a cherrypick label: new pull request created to branch |
Merged
6 tasks
|
In response to a cherrypick label: new pull request created to branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First-time contributors' checklist
What is changed, added, or deleted? (Required)
Fix an issue that the
prevent-deletion.yamlworkflow mistakenly detects image deletions when images are added or removed in the PR's base branch. The root cause of this issue is that the workflow directly compares the latest commit of the PR base branch with the latest commit of the PR.This PR improves the accuracy of the image deletion detection script by adding the
--merge-baseoption to thegit diffcommand. This change ensures that git calculates the changes from the shared starting point of the HEAD and the PR head SHA.Which TiDB Operator version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?