Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify try out htap samples #17878

Merged
merged 4 commits into from
Jun 17, 2024
Merged

modify try out htap samples #17878

merged 4 commits into from
Jun 17, 2024

Conversation

joey-yez
Copy link
Contributor

@joey-yez joey-yez commented Jun 12, 2024 •
edited by lilin90
Loading

modify samples for serverless, and add note for create tiflash replica

First-time contributors' checklist

What is changed, added or deleted? (Required)

  1. Modify the sample dataset for HTAP quickstart
  2. Fix Please check with Joey Zhang regarding the updates to replica count for serverless in the code example #17645

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@joey-yez
modify try out htap samples
ae6af65 
modify samples for serverless, and add note for create tiflash replica
@joey-yez joey-yez requested a review from qiancai June 12, 2024 10:28
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 12, 2024
JaySon-Huang
JaySon-Huang approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 13, 2024

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai self-assigned this Jun 13, 2024
@qiancai qiancai added translation/doing This PR's assignee is translating this PR. area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. ONCALL Relates to documentation oncall. labels Jun 13, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 13, 2024
qiancai
qiancai reviewed Jun 13, 2024
View reviewed changes
tidb-cloud/tidb-cloud-htap-quickstart.md Outdated Show resolved Hide resolved
tidb-cloud/tidb-cloud-htap-quickstart.md Outdated Show resolved Hide resolved
tidb-cloud/tidb-cloud-htap-quickstart.md Outdated Show resolved Hide resolved
@qiancai qiancai mentioned this pull request Jun 17, 2024
Merged
18 tasks
@qiancai qiancai requested a review from lilin90 June 17, 2024 01:25
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 17, 2024
@qiancai qiancai mentioned this pull request Jun 17, 2024
Closed
lilin90
lilin90 approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@lilin90 lilin90 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jun 17, 2024
@qiancai qiancai added needs-cherry-pick-master Should cherry pick this PR to master branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Jun 17, 2024
@qiancai
Copy link
Collaborator

qiancai commented Jun 17, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 17, 2024
This was referenced Jun 17, 2024
Merged
Merged
@ti-chi-bot ti-chi-bot bot merged commit cc25385 into pingcap:release-7.5 Jun 17, 2024
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch master: #17912.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 17, 2024
Merged
18 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #17913.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 17, 2024
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jun 17, 2024
@ti-chi-bot
modify try out htap samples (#17878) (#17913)
36aee3a
ti-chi-bot bot pushed a commit that referenced this pull request Jun 17, 2024
@ti-chi-bot
modify try out htap samples (#17878) (#17912)
cd71969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@lilin90 lilin90 lilin90 approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees

@qiancai qiancai

Labels
approved area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. lgtm needs-cherry-pick-master Should cherry pick this PR to master branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. ONCALL Relates to documentation oncall. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joey-yez @qiancai @ti-chi-bot @JaySon-Huang @lilin90