Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix transaction_atomicity #19058

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix transaction_atomicity #19058

merged 1 commit into from
Oct 10, 2024

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Oct 10, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 10, 2024
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. and removed missing-translation-status This PR does not have translation status info. contribution This PR is from a community contributor. labels Oct 10, 2024
@hfxsd hfxsd self-assigned this Oct 10, 2024
@hfxsd hfxsd requested review from lidezhu and qiancai October 10, 2024 01:29
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 10, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-10 01:43:28.294689253 +0000 UTC m=+1096763.714902265: ☑️ agreed by qiancai.

@hfxsd hfxsd added the lgtm label Oct 10, 2024
@hfxsd
Copy link
Collaborator Author

hfxsd commented Oct 10, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 10, 2024
@ti-chi-bot ti-chi-bot bot merged commit 41f78a3 into pingcap:master Oct 10, 2024
7 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #19059.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 10, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #19060.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 10, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #19061.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 10, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #19062.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 10, 2024
Merged
16 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 10, 2024
@hfxsd @ti-chi-bot
This is an automated cherry-pick of pingcap#19058
e710b2f 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #19063.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 10, 2024
Merged
16 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Oct 10, 2024
@hfxsd @ti-chi-bot
This is an automated cherry-pick of pingcap#19058
c62cfba 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #19064.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 10, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #19065.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 10, 2024
Merged
16 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Oct 10, 2024
@ti-chi-bot
fix transaction_atomicity (#19058) (#19061)
d008356
ti-chi-bot bot pushed a commit that referenced this pull request Oct 10, 2024
@ti-chi-bot
fix transaction_atomicity (#19058) (#19060)
489c33b
ti-chi-bot bot pushed a commit that referenced this pull request Oct 10, 2024
@ti-chi-bot
fix transaction_atomicity (#19058) (#19062)
c927c8c
ti-chi-bot bot pushed a commit that referenced this pull request Oct 10, 2024
@ti-chi-bot
fix transaction_atomicity (#19058) (#19063)
0433993
ti-chi-bot bot pushed a commit that referenced this pull request Oct 10, 2024
@ti-chi-bot
fix transaction_atomicity (#19058) (#19059)
28372d8
ti-chi-bot bot pushed a commit that referenced this pull request Oct 10, 2024
@ti-chi-bot
fix transaction_atomicity (#19058) (#19064)
e99dbf5
ti-chi-bot bot pushed a commit that referenced this pull request Oct 10, 2024
@ti-chi-bot
fix transaction_atomicity (#19058) (#19065)
520c6cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@lidezhu lidezhu Awaiting requested review from lidezhu

Assignees

@hfxsd hfxsd

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hfxsd @ti-chi-bot @qiancai