Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: Add LOCK TABLE, CHECK TABLE, CHECKSUM TABLE to incompatible #830

Merged
merged 3 commits into from
Jan 23, 2019
Merged

sql: Add LOCK TABLE, CHECK TABLE, CHECKSUM TABLE to incompatible #830

merged 3 commits into from
Jan 23, 2019

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Dec 27, 2018 •
edited
Loading

Checksum table: pingcap/tidb#1895
Check table: pingcap/tidb#4673
Lock table is in the ROADMAP items.

@morgo morgo changed the title sql: Add LOCK TABLE, CHECKSUM t to incompatble sql: Add LOCK TABLE, CHECKSUM TABLE to incompatble Dec 27, 2018
@morgo morgo changed the title sql: Add LOCK TABLE, CHECKSUM TABLE to incompatble sql: Add LOCK TABLE, CHECKSUM TABLE to incompatible Dec 27, 2018
@morgo morgo changed the title sql: Add LOCK TABLE, CHECKSUM TABLE to incompatible sql: Add LOCK TABLE, CHECK TABLE, CHECKSUM TABLE to incompatible Jan 14, 2019
@morgo
Copy link
Contributor Author

morgo commented Jan 14, 2019

PTAL @shenli

@morgo morgo requested a review from shenli January 14, 2019 02:22
shenli
shenli reviewed Jan 14, 2019
View reviewed changes
Copy link
Member

@shenli shenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@winkyao PTAL

@morgo morgo requested a review from CaitinChen January 14, 2019 07:30
CaitinChen
CaitinChen approved these changes Jan 23, 2019
View reviewed changes
Copy link
Contributor

@CaitinChen CaitinChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaitinChen CaitinChen merged commit a7c3245 into master Jan 23, 2019
@lilin90 lilin90 deleted the morgo/add-unsupported branch January 23, 2019 12:17
yikeke pushed a commit to yikeke/docs-cn that referenced this pull request Jan 29, 2019
sql: add three unsupported features to imcompatible
594521f 
Via: pingcap/docs#830
@yikeke yikeke mentioned this pull request Jan 29, 2019
Merged
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shenli shenli shenli left review comments

@CaitinChen CaitinChen CaitinChen approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@morgo @shenli @CaitinChen @sre-bot