Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: error TPM. Added: show current TPM #34

Merged
merged 1 commit into from
Mar 29, 2020
Merged

Fixed: error TPM. Added: show current TPM #34

merged 1 commit into from
Mar 29, 2020

Conversation

innerr
Copy link
Contributor

@innerr innerr commented Mar 28, 2020 •
edited
Loading

Signed-off-by: Liu Cong innerr@gmail.com

1, The TPM was not correct, especially happened on error TPM, it caused by the incorrect start-time of hist , this PR fixed that

2, This PR added a param --summary:

  • When it's true, print summary measurements on each tick
  • When it's false(by default), print current measurements on each tick, and print summary's on each 10 ticks

3, Print conflicted errors

@innerr
Fixed: error TPM. Added: show current TPM
33e8c79 
Signed-off-by: Liu Cong <innerr@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Mar 28, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mahjonp
mahjonp approved these changes Mar 28, 2020
View reviewed changes
Copy link
Contributor

@mahjonp mahjonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this problem I have also occurred before.

@coocood
Copy link
Member

coocood commented Mar 29, 2020

LGTM

@coocood coocood merged commit d65f05c into pingcap:master Mar 29, 2020
@innerr innerr deleted the tpm-improv branch March 30, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouqiang-cl zhouqiang-cl zhouqiang-cl left review comments

@mahjonp mahjonp mahjonp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@innerr @CLAassistant @coocood @mahjonp @zhouqiang-cl