Pick: Added a new PrepareBackup RPC for snapshot backup (#1204)
#1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added basic proto Signed-off-by: hillium <yujuncen@pingcap.com> * finish Signed-off-by: hillium <yujuncen@pingcap.com> * update new version of advanced prepare Signed-off-by: hillium <yujuncen@pingcap.com> * added some comments and a new request type Signed-off-by: hillium <yujuncen@pingcap.com> * added more comments Signed-off-by: hillium <yujuncen@pingcap.com> * make go Signed-off-by: hillium <yujuncen@pingcap.com> * address comments Signed-off-by: hillium <yujuncen@pingcap.com> --------- Signed-off-by: hillium <yujuncen@pingcap.com>
BornChanger
approved these changes
Feb 20, 2024
Signed-off-by: hillium <yujuncen@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added basic proto
finish
update new version of advanced prepare
added some comments and a new request type
added more comments
make go
address comments