Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: add congested error #1267

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Sep 9, 2024

part of tikv/tikv#17503

@ti-chi-bot ti-chi-bot bot requested review from fzzf678 and yibin87 September 9, 2024 08:08
@CLAassistant
Copy link

CLAassistant commented Sep 9, 2024

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added the size/XL label Sep 9, 2024
@3AceShowHand 3AceShowHand requested review from overvenus and hicqu and removed request for yibin87 and fzzf678 September 9, 2024 08:20
Copy link

ti-chi-bot bot commented Sep 9, 2024

@hicqu: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3AceShowHand
Copy link
Contributor Author

@overvenus PTAL

@@ -46,6 +53,7 @@ message Error {
Compatibility compatibility = 5;
ClusterIDMismatch cluster_id_mismatch = 6;
errorpb.ServerIsBusy server_is_busy = 7;
Congested congested = 8;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does old TiCDC handle this error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old TiCDC treat this congested error as unknown error, print logs.

@ti-chi-bot ti-chi-bot bot removed the lgtm label Sep 11, 2024
Copy link

ti-chi-bot bot commented Sep 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-11 08:41:20.111281805 +0000 UTC m=+432149.851705744: ☑️ agreed by overvenus.
  • 2024-09-11 08:44:48.320751859 +0000 UTC m=+432358.061175814: ☑️ agreed by YuJuncen.
  • 2024-09-11 08:46:28.171726086 +0000 UTC m=+432457.912150027: ✖️🔁 reset by 3AceShowHand.

Copy link

ti-chi-bot bot commented Sep 11, 2024

New changes are detected. LGTM label has been removed.

Copy link

ti-chi-bot bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hicqu, overvenus, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 1a933d3 into pingcap:master Sep 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants