Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test #18

Merged
merged 3 commits into from
Jul 6, 2020
Merged

fix test #18

merged 3 commits into from
Jul 6, 2020

Conversation

baurine
Copy link
Contributor

@baurine baurine commented Jul 3, 2020

  • 1 second to load server info is too short, always fails
  • although 2 seconds can make test pass, prefer to increase larger

error logs when fails:

> make
Running in native mode.

----------------------------------------------------------------------
FAIL: service_test.go:63: serviceSuite.TestRPCServerInfo

service_test.go:77:
    c.Assert(err, IsNil)
... value *status.statusError = &status.statusError{Code:4, Message:"context deadline exceeded", Details:[]*any.Any(nil), XXX_NoUnkeyedLiteral:struct {}{}, XXX_unrecognized:[]uint8(nil), XXX_sizecache:0} ("rpc error: code = DeadlineExceeded desc = context deadline exceeded")

OOPS: 4 passed, 1 FAILED
--- FAIL: TestT (1.04s)
FAIL
coverage: 56.1% of statements
FAIL    github.com/pingcap/sysutil      3.373s
FAIL
make: *** [gotest] Error 1

- 1 second to load server info is too short, always fails
- although 2 seconds can make test pass, prefer to increase larger
@baurine
Copy link
Contributor Author

baurine commented Jul 3, 2020

@crazycs520 @lonng PTAL, thanks!

Copy link
Collaborator

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 merged commit f8bc619 into pingcap:master Jul 6, 2020
@baurine baurine deleted the fix-test branch July 6, 2020 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants