Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase timeout to 60s when connecting to tidb database #879

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Mar 25, 2021

close #878

but in fact, we have kinds of timeout, not sure whether it is ok to only increase this timeout.

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@breezewish
Copy link
Member

@baurine We also have other kind of timeouts, like proxy timeout. Could you confirm this behaviour? (e.g. whether increasing the proxy timeout is necessary).

@baurine
Copy link
Collaborator Author

baurine commented Mar 26, 2021

@baurine We also have other kind of timeouts, like proxy timeout. Could you confirm this behaviour? (e.g. whether increasing the proxy timeout is necessary).

ok, I will check it.

@breezewish breezewish force-pushed the master branch 2 times, most recently from b4a5d28 to ab56290 Compare July 9, 2021 10:30
@breezewish
Copy link
Member

Seems that there is no proxy timeout. I think we can go on for now and see whether it can be improved in future.

One thing to do: Now we have some connection logic in tidb-dashboard/util. Could you also add timeout settings for it, so that we will not meet regressions when switching to it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard cannot use under heavy load
3 participants