Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

Consistent -c / -C for configuration file option #68

Closed
morgo opened this issue Sep 14, 2018 · 4 comments
Closed

Consistent -c / -C for configuration file option #68

morgo opened this issue Sep 14, 2018 · 4 comments

Comments

@morgo
Copy link

morgo commented Sep 14, 2018

Minor issue:

tikv-importer uses a capital -C for the config file option versus tidb-lightning that uses a lower case -c. Is it possible to make these consistent?

Additional research:

  • tidb: does not have single letter flag (-config)
  • tikv: uses capital -C
  • pd: does not have a single letter flag (-config)
@kennytm
Copy link
Collaborator

kennytm commented Sep 14, 2018

(Also tracked in Jira as TOOL-363.)

Further information for our other tools

Project Binary Flag
tidb-binlog drainer -config (-c means "parallel worker count")
tidb-binlog pump -config
tidb-enterprise-tools syncer -config
tidb-enterprise-tools loader -config

I think we must add -config in additional to -c. But I don't think we should remove -c or change it to -C as this will unnecessarily break backward compatibility.

@morgo
Copy link
Author

morgo commented Sep 14, 2018

In unreleased tools, it is okay to break backwards compatibility (why I bring it up now :-)).

But in released tools: yes, best not to change.

@kennytm
Copy link
Collaborator

kennytm commented Sep 14, 2018

Unfortunately the tool has given to several customers already so it's not completely unreleased 😂.

@morgo
Copy link
Author

morgo commented Sep 14, 2018

OK :-) My mistake.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants