configure the operator ServiceAccount #111
Conversation
|
When RBAC is enabled, we should create a ServiceAccount for controller-manager. I don't think it's necessary to allow users to specify the ServiceAccount for controller-manager, since we've already created the ServiceAccount named |
|
I added a commit that also makes the ServiceAccount creation optional (even if rbac is true). |
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
|
@gregwebs we need to change images/tidb-operator-values.yaml also when the values.yaml changed, otherwise it can not pass e2e test , because ci use the file to replace the charts/tidb-operator/values.yaml. |
|
/run-e2e-tests |
| --- | ||
| kind: ServiceAccount | ||
| apiVersion: v1 | ||
| metadata: | ||
| name: tidb-controller-manager | ||
| name: {{ .Values.controllerManager.ServiceAccount }} |
There was a problem hiding this comment.
It's serviceAccount not ServiceAccount. User-defined variables are lower case.
|
/run-e2e-tests |
1 similar comment
|
/run-e2e-tests |
* configure the operator ServiceAccount * make SeriveAccount resource creation optional * e2e: create the serviceAccount * fix lower-case serviceAccount
* Update scale-a-tidb-cluster.md * Apply suggestions from code review Co-Authored-By: TomShawn <41534398+TomShawn@users.noreply.github.com> Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
This allows the serviceAccount to be configured from values.yaml. I am not sure if this should be directly connected to rbac.create or not.