bump TiDB to v2.1.0 #212
Merged
bump TiDB to v2.1.0 #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weekface
previously approved these changes
Dec 5, 2018
|
/run-e2e-tests |
2 similar comments
|
/run-e2e-tests |
|
/run-e2e-tests |
xiaojingchen
reviewed
Dec 6, 2018
| binlog-socket = "" | ||
| [binlog] | ||
| # enable to write binlog. | ||
| enable = false |
There was a problem hiding this comment.
should this field be managed in Values.yaml?
There was a problem hiding this comment.
The command line arguments override the configuration file.
gregwebs
reviewed
Dec 6, 2018
| @@ -26,3 +26,17 @@ pd-urls = "http://{{ .Values.clusterName }}-pd:2379" | |||
| # ssl-cert = "/path/to/drainer.pem" | |||
| # Path of file that contains X509 key in PEM format for connection with cluster components. | |||
| # ssl-key = "/path/to/drainer-key.pem" | |||
| # | |||
| # | |||
| # we suggest using the default config of the embedded LSM DB now, do not change it useless you know what you are doing | |||
There was a problem hiding this comment.
Nice catch! This is copied from tidb-binlog repo, you can also send a PR there for the typo :-)
…tor into bump-tidb-2.1.0
weekface
approved these changes
Dec 6, 2018
|
/run-e2e-tests |
|
/run-e2e-tests |
queenliuxx
pushed a commit
to queenliuxx/tidb-operator
that referenced
this pull request
Dec 19, 2018
* bump TiDB to v2.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #212