Polish documents #213
Merged
Polish documents #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tennix
force-pushed
the
polish-user-guide
branch
from
e3cdb3d
to
ba3cff5
Compare
gregwebs
reviewed
Dec 6, 2018
|
Lgtm |
xiaojingchen
reviewed
Dec 6, 2018
docs/google-kubernetes-tutorial.md
Outdated
| When the TiDB cluster is not needed, you can delete with the following command: | ||
|
|
||
| helm delete tidb --purge && | ||
| kubectl delete |
There was a problem hiding this comment.
what the kubectl delete mean?
xiaojingchen
reviewed
Dec 6, 2018
docs/google-kubernetes-tutorial.md
Outdated
| When the TiDB cluster is not needed, you can delete with the following command: | ||
|
|
||
| helm delete tidb --purge && | ||
| kubectl delete |
There was a problem hiding this comment.
what the kubectl delete mean?
weekface
reviewed
Dec 6, 2018
docs/google-kubernetes-tutorial.md
Outdated
| When the TiDB cluster is not needed, you can delete with the following command: | ||
|
|
||
| helm delete tidb --purge && | ||
| kubectl delete |
docs/google-kubernetes-tutorial.md
Outdated
| @@ -154,6 +154,18 @@ Now the number of TiKV pods is increased from the default 3 to 5. You can check | |||
|
|
|||
| kubectl get po -n tidb | |||
|
|
|||
| ## Destroy the TiDB cluster | |||
|
|
|||
| When the TiDB cluster is not needed, you can delete with the following command: | |||
There was a problem hiding this comment.
Suggested change
| When the TiDB cluster is not needed, you can delete with the following command: | |
| When the TiDB cluster is not needed, you can delete it with the following commands: |
docs/google-kubernetes-tutorial.md
Outdated
| helm delete tidb --purge && | ||
| kubectl delete | ||
|
|
||
| The above commands only delete the running pods, the data is persistent. If you do not need the data anymore, you should run the following command to clean the data and the dynamically created persistent disks: |
There was a problem hiding this comment.
Suggested change
| The above commands only delete the running pods, the data is persistent. If you do not need the data anymore, you should run the following command to clean the data and the dynamically created persistent disks: | |
| The above commands only delete the running pods, the data is persistent. If you do not need the data anymore, you should run the following commands to clean the data and the dynamically created persistent disks: |
|
|
||
| The above commands only delete the running pods, the data is persistent. If you do not need the data anymore, you should run the following command to clean the data and the dynamically created persistent disks: | ||
|
|
||
| kubectl delete pvc -n tidb -l app.kubernetes.io/instance=tidb,app.kubernetes.io/managed-by=tidb-operator && |
There was a problem hiding this comment.
This is a dangerous operation, give user a warning?
There was a problem hiding this comment.
Since it's just a tutorial, and the statement above the command already said it will clean the data and persistent disks. So not a big problem I think.
weekface
approved these changes
Dec 13, 2018
xiaojingchen
approved these changes
Dec 26, 2018
This was referenced Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR polishes the documents: