Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unreachable code #3522

Closed
wants to merge 1 commit into from
Closed

Remove unreachable code #3522

wants to merge 1 commit into from

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

Remove unreachable code

What is changed and how does it work?

Remove unreachable code

Check List

Tests

  • No code

Code changes

  • Has Go code change

Side effects

None

Related changes

None

Does this PR introduce a user-facing change?:

NONE

@CLAassistant
Copy link

CLAassistant commented Nov 25, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@DanielZhangQD
Copy link
Contributor

/lgtm

@Rustin170506
Copy link
Member Author

/lgtm

@ti-chi-bot
Copy link
Member

@hi-rustin: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository.

@DanielZhangQD
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@DanielZhangQD: adding 'status/can-merge' to this PR must have 2 LGTMs

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository.

@codecov-io
Copy link

Codecov Report

Merging #3522 (c9f8758) into master (2ef7128) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3522   +/-   ##
=======================================
  Coverage   60.32%   60.32%           
=======================================
  Files         162      162           
  Lines       16725    16725           
=======================================
  Hits        10089    10089           
  Misses       5675     5675           
  Partials      961      961
Flag Coverage Δ
unittest 60.32% <ø> (?)

@handlerww
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

@handlerww: adding LGTM is restricted to reviewers in list.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository.

@Rustin170506
Copy link
Member Author

/test-pull-e2e-kind

@Rustin170506 Rustin170506 mentioned this pull request Nov 25, 2020
Closed
1 task
@Rustin170506
Copy link
Member Author

/test-pull-e2e-kind

@Rustin170506
Copy link
Member Author

/auto-cc

@Rustin170506
Copy link
Member Author

/auto-cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiffang qiffang Awaiting requested review from qiffang

@aylei aylei Awaiting requested review from aylei

@AstroProfundis AstroProfundis Awaiting requested review from AstroProfundis

Assignees
No one assigned
Labels
status/LGT1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rustin170506 @CLAassistant @DanielZhangQD @ti-chi-bot @codecov-io @handlerww