Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support PD TSO & Scheduling service #5398

Merged
merged 28 commits into from
Dec 29, 2023
Merged

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Nov 17, 2023

image

What problem does this PR solve?

What is changed and how does it work?

  pd:
    baseImage: hub.pingcap.net/devbuild/pd
    version: v7.5.0-2622
    maxFailoverCount: 0
    replicas: 1
    # if storageClassName is not set, the default Storage Class of the Kubernetes cluster will be used
    # storageClassName: local-storage
    requests:
      storage: "1Gi"
    config: {}
    mode: "ms"
  pdms:
    - name: "tso"
      baseImage: hub.pingcap.net/devbuild/pd
      version: v7.5.0-2622
      maxFailoverCount: 0
      replicas: 1
      config: {}
    - name: "scheduling"
      baseImage: hub.pingcap.net/devbuild/pd
      version: v7.5.0-2622
      maxFailoverCount: 0
      replicas: 1
      config: {}

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@HuSharp HuSharp force-pushed the delopy_pd_tso branch 3 times, most recently from 83c83d3 to 9ccbd84 Compare November 24, 2023 07:51
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp force-pushed the delopy_pd_tso branch 2 times, most recently from 3d87ddf to 11bea72 Compare November 29, 2023 07:51
@HuSharp HuSharp marked this pull request as ready for review November 29, 2023 07:53
@ti-chi-bot ti-chi-bot bot requested a review from shonge November 29, 2023 07:53
@HuSharp HuSharp changed the title [DNM] support tso service *: support tso service Nov 29, 2023
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2023

Codecov Report

Attention: 403 lines in your changes are missing coverage. Please review.

Comparison is base (be648db) 61.58% compared to head (2fae34a) 67.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5398      +/-   ##
==========================================
+ Coverage   61.58%   67.22%   +5.63%     
==========================================
  Files         230      245      +15     
  Lines       29179    33778    +4599     
==========================================
+ Hits        17971    22707    +4736     
+ Misses       9434     9201     -233     
- Partials     1774     1870      +96     
Flag Coverage Δ
e2e 46.42% <6.09%> (?)
unittest 61.39% <54.42%> (-0.20%) ⬇️

@HuSharp
Copy link
Contributor Author

HuSharp commented Dec 1, 2023

@csuzhangxc PTAL, thx!

Signed-off-by: husharp <jinhao.hu@pingcap.com>
examples/basic/tidb-cluster.yaml Outdated Show resolved Hide resolved
pkg/apis/label/label.go Outdated Show resolved Hide resolved
pkg/apis/pingcap/v1alpha1/component_spec.go Outdated Show resolved Hide resolved
pkg/apis/pingcap/v1alpha1/tidbcluster.go Outdated Show resolved Hide resolved
pkg/apis/pingcap/v1alpha1/tidbcluster.go Show resolved Hide resolved
pkg/apis/pingcap/v1alpha1/types.go Show resolved Hide resolved
HuSharp and others added 4 commits December 21, 2023 14:58
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
Signed-off-by: husharp <jinhao.hu@pingcap.com>
pkg/apis/pingcap/v1alpha1/tidbcluster.go Outdated Show resolved Hide resolved
pkg/apis/pingcap/v1alpha1/tidbcluster.go Show resolved Hide resolved
pkg/apis/pingcap/v1alpha1/tidbcluster.go Outdated Show resolved Hide resolved
pkg/apis/pingcap/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/apis/pingcap/v1alpha1/types.go Outdated Show resolved Hide resolved
pkg/manager/member/startscript/v1/template.go Outdated Show resolved Hide resolved
pkg/manager/member/startscript/v1/template.go Outdated Show resolved Hide resolved
pkg/manager/member/tikv_member_manager.go Outdated Show resolved Hide resolved
pkg/manager/suspender/suspender.go Outdated Show resolved Hide resolved
pkg/pdapi/pd_control.go Outdated Show resolved Hide resolved
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@csuzhangxc
Copy link
Member

/run-all-tests

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Contributor Author

HuSharp commented Dec 22, 2023

/run-all-tests

@csuzhangxc
Copy link
Member

/run-pull-e2e-kind

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Contributor Author

HuSharp commented Dec 22, 2023

/run-pull-e2e-kind

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Contributor Author

HuSharp commented Dec 25, 2023

/run-pull-e2e-kind

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Contributor Author

HuSharp commented Dec 25, 2023

/run-pull-e2e-kind

1 similar comment
@HuSharp
Copy link
Contributor Author

HuSharp commented Dec 27, 2023

/run-pull-e2e-kind

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Contributor Author

HuSharp commented Dec 28, 2023

/run-pull-e2e-kind

@HuSharp
Copy link
Contributor Author

HuSharp commented Dec 28, 2023

/run-all-tests

@HuSharp
Copy link
Contributor Author

HuSharp commented Dec 28, 2023

/run-pull-e2e-kind-across-kubernetes

1 similar comment
@HuSharp
Copy link
Contributor Author

HuSharp commented Dec 28, 2023

/run-pull-e2e-kind-across-kubernetes

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 29, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-29 09:00:35.311938765 +0000 UTC m=+1815526.349165709: ☑️ agreed by csuzhangxc.

Copy link
Contributor

ti-chi-bot bot commented Dec 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 29, 2023
@csuzhangxc csuzhangxc merged commit 03a0c76 into pingcap:master Dec 29, 2023
6 checks passed
@HuSharp HuSharp deleted the delopy_pd_tso branch December 29, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants