Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdms: PD default using start script v2 with WaitForDnsNameIpMatch when enables PDMS #5564

Merged
merged 7 commits into from
Mar 7, 2024
Merged

pdms: PD default using start script v2 with WaitForDnsNameIpMatch when enables PDMS #5564

merged 7 commits into from
Mar 7, 2024

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Mar 6, 2024 •
edited
Loading

What problem does this PR solve?

Ref tikv/pd#7519 , #5381

PD&PDMS use start script v2 and enabling feature WaitForDnsNameIpMatch when enabled PDMS

need to check IP firstly

$ kubectl logs -f basic-pd-0 -n pingcap
domain resolve basic-pd-0.basic-pd-peer.pingcap.svc success
10.244.0.64
hostIps: 10.244.0.69
resolvedIps: 10.244.0.64
Resolved IP does not match any of podIPs
domain resolve basic-pd-0.basic-pd-peer.pingcap.svc success
10.244.0.64
hostIps: 10.244.0.69
resolvedIps: 10.244.0.64
Resolved IP does not match any of podIPs
domain resolve basic-pd-0.basic-pd-peer.pingcap.svc success
10.244.0.64
hostIps: 10.244.0.69
resolvedIps: 10.244.0.64
Resolved IP does not match any of podIPs
domain resolve basic-pd-0.basic-pd-peer.pingcap.svc success
...
10.244.0.64
hostIps: 10.244.0.69
resolvedIps: 10.244.0.64
Resolved IP does not match any of podIPs
domain resolve basic-pd-0.basic-pd-peer.pingcap.svc success
domain resolve basic-pd-0.basic-pd-peer.pingcap.svc success
10.244.0.69
hostIps: 10.244.0.69
resolvedIps: 10.244.0.69
Success: Resolved IP matches one of podIPs
starting pd-server ...

What is changed and how does it work?

Tests

  • Unit test
  • E2E test
  • Manual test

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@HuSharp
support v2 start script
85e8398 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@ti-chi-bot ti-chi-bot bot requested a review from shonge March 6, 2024 00:00
@HuSharp HuSharp removed the request for review from shonge March 6, 2024 00:00
@ti-chi-bot ti-chi-bot bot added the size/XXL label Mar 6, 2024
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.91304% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 67.75%. Comparing base (4d45e49) to head (b5cf22d).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5564      +/-   ##
==========================================
+ Coverage   61.51%   67.75%   +6.23%     
==========================================
  Files         235      246      +11     
  Lines       30179    34049    +3870     
==========================================
+ Hits        18566    23071    +4505     
+ Misses       9756     9096     -660     
- Partials     1857     1882      +25
Flag Coverage Δ
e2e 48.13% <63.04%> (?)
unittest 61.47% <46.51%> (-0.04%) ⬇️

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-all-tests

@HuSharp HuSharp mentioned this pull request Mar 6, 2024
Closed
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-all-tests

@HuSharp HuSharp requested a review from csuzhangxc March 6, 2024 02:35
@HuSharp
support v2 start script to pdms
978ca15 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp HuSharp changed the title pdms: support WaitForDnsNameIpMatch in start script v2 pdms: default using start script v2 with WaitForDnsNameIpMatch Mar 6, 2024
@HuSharp
add comment to start script
fe40b66 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-all-tests

csuzhangxc
csuzhangxc reviewed Mar 6, 2024
View reviewed changes
pkg/apis/pingcap/v1alpha1/types.go Outdated
@@ -151,6 +151,7 @@ type StartScriptVersion string

const (
StartScriptV1 StartScriptVersion = "v1"
// When PD enables microservice mode, we will use start script v2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about updating TidbCluster.spec.StartScriptVersion?

@HuSharp
add comment to start script
a4ce030 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-all-tests

@HuSharp
merge master
876c45f 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-all-tests

1 similar comment
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-all-tests

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-pull-e2e-kind-across-kubernetes

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-pull-e2e-kind-basic

1 similar comment
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-pull-e2e-kind-basic

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-pull-e2e-kind

1 similar comment
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-pull-e2e-kind

@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 6, 2024

/run-pull-e2e-kind-basic

@HuSharp
refine start script v2
47301f7 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 7, 2024

/run-all-tests

@HuSharp HuSharp changed the title pdms: default using start script v2 with WaitForDnsNameIpMatch pdms: PD default using start script v2 with WaitForDnsNameIpMatch when enables PDMS Mar 7, 2024
@csuzhangxc
Copy link
Member

/run-pull-e2e-kind-basic

@HuSharp
replace image
b5cf22d 
Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Contributor Author

HuSharp commented Mar 7, 2024

/run-all-tests

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 7, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-07 03:52:04.007009731 +0000 UTC m=+311951.029256111: ☑️ agreed by csuzhangxc.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csuzhangxc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 7, 2024
@ti-chi-bot ti-chi-bot bot merged commit 88a18ac into pingcap:master Mar 7, 2024
12 of 13 checks passed
@HuSharp HuSharp deleted the support_pdms_start_script_v2 branch March 7, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HuSharp @codecov-commenter @csuzhangxc