Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor CompareDatum #29867

Closed
wjhuang2016 opened this issue Nov 17, 2021 · 0 comments · Fixed by #30815
Closed

refactor CompareDatum #29867

wjhuang2016 opened this issue Nov 17, 2021 · 0 comments · Fixed by #30815
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@wjhuang2016
Copy link
Member

Enhancement

CompareDatum uses collation implicitly which tends to error.
So we need to add an argument collator explicitly.
@wjhuang2016 wjhuang2016 added the type/enhancement The issue or PR belongs to an enhancement. label Nov 17, 2021
This was referenced Nov 17, 2021
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 24, 2021
Merged
Merged
This was referenced Dec 6, 2021
Merged
Merged
Merged
Merged
This was referenced Dec 14, 2021
Merged
Merged
This was referenced Feb 14, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

types, util: clean up compareDatum wjhuang2016/tidb
1 participant
@wjhuang2016