Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightning does not use auto-sync and fails when the PD cluster address changed #43436

Closed
lichunzhu opened this issue Apr 26, 2023 · 1 comment · Fixed by #45680 or #46726
Closed

Lightning does not use auto-sync and fails when the PD cluster address changed #43436

lichunzhu opened this issue Apr 26, 2023 · 1 comment · Fixed by #45680 or #46726
Assignees
@lichunzhu
Labels
affects-6.5 affects-7.1 affects-7.3 component/lightning This issue is related to Lightning of TiDB. severity/moderate type/bug This issue is a bug.

Comments

@lichunzhu
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. Start a TiDB cluster with 3 PDs ① ② ③ and a Lightning connected
  2. Scale-out 3 more PDs ④ ⑤ ⑥
  3. Wait 31 seconds
  4. Scale-in the original PDs ① ② ③
  5. Wait 31 seconds
  6. Keep Lightning running.

2. What did you expect to see? (Required)

We make sure lightning succeed.

3. What did you see instead (Required)

Lightning will fail in some cases due to no valid pd-addr.

4. What is your TiDB version? (Required)

master
@lichunzhu lichunzhu added type/bug This issue is a bug. severity/minor component/lightning This issue is related to Lightning of TiDB. affects-6.5 affects-7.1 labels Apr 26, 2023
@lance6716 lance6716 changed the title The etcd client to the registry of Lightning does not use auto-sync and fails when the PD cluster address changed Lightning does not use auto-sync and fails when the PD cluster address changed May 31, 2023
@lichunzhu lichunzhu mentioned this issue Jul 31, 2023
Merged
1 task
ti-chi-bot bot pushed a commit that referenced this issue Aug 1, 2023
@lichunzhu
lightning: fix pd http request using old address (#45680)
9c213aa 
close #43436
This was referenced Aug 1, 2023
Merged
Merged
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this issue Aug 1, 2023
@lichunzhu @ti-chi-bot
lightning: fix pd http request using old address (pingcap#45680)
d240f00 
close pingcap#43436
ti-chi-bot bot pushed a commit that referenced this issue Aug 4, 2023
@ti-chi-bot
lightning: fix pd http request using old address (#45680) (#45737)
203d839 
close #43436
ti-chi-bot bot pushed a commit that referenced this issue Aug 16, 2023
@ti-chi-bot
lightning: fix pd http request using old address (#45680) (#45728)
415c36c 
close #43436
@lance6716 lance6716 mentioned this issue Sep 6, 2023
Closed
@lance6716 lance6716 reopened this Sep 6, 2023
@lance6716
Copy link
Contributor

lance6716 commented Sep 6, 2023 •
edited
Loading

many PD address usages not removed

@lance6716 lance6716 mentioned this issue Sep 6, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 7, 2023
@lance6716
lightning: always get latest PD leader when access PD after initializ…
41d1ec0 
…ed (#46726)

close #43436, close #46688
This was referenced Sep 7, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Sep 11, 2023
@ti-chi-bot
lightning: always get latest PD leader when access PD after initializ…
a4aec47 
…ed (#46726) (#46757)

close #43436, close #46688
@lijie0123 lijie0123 mentioned this issue Sep 21, 2023
Closed
11 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 17, 2023
@ti-chi-bot
lightning: fix pd http request using old address (#45680) (#45726)
acdac74 
close #43436
ti-chi-bot bot pushed a commit that referenced this issue Oct 17, 2023
@ti-chi-bot
lightning: always get latest PD leader when access PD after initializ…
49e9daf 
…ed (#46726) (#46758)

close #43436, close #46688
yibin87 pushed a commit to yibin87/tidb that referenced this issue Oct 31, 2023
@lance6716 @yibin87
lightning: always get latest PD leader when access PD after initializ…
52fc824 
…ed (pingcap#46726)

close pingcap#43436, close pingcap#46688
guoshouyan pushed a commit to guoshouyan/tidb that referenced this issue Mar 5, 2024
@ti-chi-bot @mittalrishabh
lightning: always get latest PD leader when access PD after initializ…
360a34b 
…ed (pingcap#46726) (pingcap#46757)

close pingcap#43436, close pingcap#46688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lichunzhu lichunzhu

Labels
affects-6.5 affects-7.1 affects-7.3 component/lightning This issue is related to Lightning of TiDB. severity/moderate type/bug This issue is a bug.
Projects
None yet
Milestone
No milestone
3 participants
@lance6716 @lichunzhu @ti-chi-bot