lightning: always get latest PD leader when access PD after initialized #46726
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
ti-chi-bot
bot
added
do-not-merge/work-in-progress
|
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #46726 +/- ##
================================================
+ Coverage 73.3566% 74.9629% +1.6062%
================================================
Files 1318 1360 +42
Lines 395847 402343 +6496
================================================
+ Hits 290380 301608 +11228
+ Misses 86993 81233 -5760
- Partials 18474 19502 +1028
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lance6716
changed the title
lance6716
changed the title
ti-chi-bot
bot
removed
do-not-merge/work-in-progress
| func (p *PdController) getAllPDAddrs() []string { | ||
| ret := make([]string, 0, len(p.addrs)+1) | ||
| if p.pdClient != nil { | ||
| ret = append(ret, p.pdClient.GetLeaderAddr()) |
There was a problem hiding this comment.
PdController is shared by BR, @3pointer PTAL
|
/check-issue-triage-complete |
ti-chi-bot
bot
added
needs-cherry-pick-release-6.5
needs-cherry-pick-release-7.1
and removed
do-not-merge/needs-triage-completed
labels
lance6716
changed the title
|
/test pull-br-integration-test |
|
@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
/test pull-br-integration-test |
|
@D3Hunter: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| check_contains 'count(*): 4' | ||
| check_contains 'sum(c): 46' | ||
|
|
||
| restart_services |
There was a problem hiding this comment.
the old pd is killed, I'm afraid other tests will access the dead pd by address
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, D3Hunter The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
1 similar comment
|
/retest |
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
lightning test passed before. You can see the commit hash is same |
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
|
/retest |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: close #46688 close #43436
Problem Summary:
What is changed and how it works?
PD nodes may change, so lightning should always try to use latest informtion rather than the addresses in task configuration.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.