Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightning: always get latest PD leader when access PD after initialized (#46726) #46758

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #46726

What problem does this PR solve?

Issue Number: close #46688 close #43436

Problem Summary:

What is changed and how it works?

PD nodes may change, so lightning should always try to use latest informtion rather than the addresses in task configuration.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 labels Sep 7, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 7, 2023
Signed-off-by: lance6716 <lance6716@gmail.com>
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 11, 2023
@lance6716
Copy link
Contributor

waiting for #45726

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 25, 2023
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2023
@D3Hunter
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 17, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 17, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 17, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-10-17 02:43:29.39033071 +0000 UTC m=+1711406.977440854: ☑️ agreed by D3Hunter.
  • 2023-10-17 02:53:34.0749094 +0000 UTC m=+1712011.662019544: ☑️ agreed by lance6716.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@acdac74). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #46758   +/-   ##
================================================
  Coverage               ?   73.4362%           
================================================
  Files                  ?       1206           
  Lines                  ?     377484           
  Branches               ?          0           
================================================
  Hits                   ?     277210           
  Misses                 ?      82584           
  Partials               ?      17690           

@ti-chi-bot ti-chi-bot bot merged commit 49e9daf into pingcap:release-7.1 Oct 17, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants