Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessionctx: support fast analyze session control variable. #10039

Merged
merged 5 commits into from
Apr 4, 2019
Merged

sessionctx: support fast analyze session control variable. #10039

merged 5 commits into from
Apr 4, 2019

Conversation

lzmhhh123
Copy link
Contributor

What problem does this PR solve?

A sub PR for fast analyze. Reference: #9973

What is changed and how it works?

Just add a sessionctx variable.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported variable/fields change
  • Has persistent data change

Side effects

  • Increased code complexity

Related changes

  • Need to update the documentation
  • Need to be included in the release note

@lzmhhh123 lzmhhh123 mentioned this pull request Apr 4, 2019
Closed
@lzmhhh123 lzmhhh123 mentioned this pull request Apr 4, 2019
Merged
alivxxx
alivxxx reviewed Apr 4, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add it in builtinGlobalVariable?

sessionctx/variable/session.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 4, 2019 •
edited
Loading

Codecov Report

Merging #10039 into master will decrease coverage by 0.2191%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10039        +/-   ##
================================================
- Coverage   77.7345%   77.5153%   -0.2192%     
================================================
  Files           403        403                
  Lines         81916      81918         +2     
================================================
- Hits          63677      63499       -178     
- Misses        13554      13708       +154     
- Partials       4685       4711        +26

alivxxx
alivxxx reviewed Apr 4, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 4, 2019
zz-jason
zz-jason approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 4, 2019
@zz-jason
Copy link
Member

zz-jason commented Apr 4, 2019 •
edited
Loading

@lzmhhh123 we also need to update the document

@lzmhhh123
Copy link
Contributor Author

@zz-jason Yes, I will update it in the doc.

@zz-jason zz-jason merged commit 2e5f7a4 into pingcap:master Apr 4, 2019
@lzmhhh123 lzmhhh123 deleted the dev/fast_analyze_session_control branch July 24, 2019 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eurekaka eurekaka eurekaka left review comments

@alivxxx alivxxx alivxxx left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
component/session status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lzmhhh123 @zz-jason @eurekaka @alivxxx