executor, privileges: fix privileges check fail for SET DEFAULT ROLE
#11201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11201 +/- ##
===========================================
Coverage ? 81.0424%
===========================================
Files ? 423
Lines ? 90022
Branches ? 0
===========================================
Hits ? 72956
Misses ? 11780
Partials ? 5286 |
Codecov Report
@@ Coverage Diff @@
## master #11201 +/- ##
===========================================
Coverage 81.9629% 81.9629%
===========================================
Files 434 434
Lines 95276 95276
===========================================
Hits 78091 78091
Misses 11744 11744
Partials 5441 5441 |
|
/run-all-tests tidb-test=pr/847 |
|
PTAL @tiancaiamao @lysu |
tiancaiamao
reviewed
Jul 19, 2019
tiancaiamao
reviewed
Aug 2, 2019
tiancaiamao
reviewed
Aug 2, 2019
| func (e *SimpleExec) releaseSysSession(ctx sessionctx.Context) { | ||
| dom := domain.GetDomain(e.ctx) | ||
| sysSessionPool := dom.SysSessionPool() | ||
| sysSessionPool.Put(ctx.(pools.Resource)) |
There was a problem hiding this comment.
sysSessionPool.Put(ctx) should work, and import "github.com/ngaut/pools" is not necessary.
|
LGTM @lysu |
|
/run-all-tests |
|
/run-all-tests |
|
/run-unit-test |
jackysp
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 in PR #11774 |
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Aug 19, 2019
sre-bot
pushed a commit
that referenced
this pull request
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #11165
SET DEFAULT ROLEshould always be avaible forcurrent_userWhat is changed and how it works?
Implement
setDefaultRoleForCurrentUser.Remove original privilege check for
SET DEFAULT ROLE.Add new privilege check for
SET DEFAULT ROLE.If is setting default role for current user, just skip check and call
setDefaultRoleForCurrentUser.Check List
Tests
Code changes
Side effects
Related changes