executor: add rollback in releaseSysSession
#14269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysu
added
needs-cherry-pick-3.0
priority/release-blocker
|
/run-all-tests |
lysu
added
Priority/P1
|
Do you know which internal session fails to call commit/rollback? @lysu |
|
@tiancaiamao for example this line Line 870 in 04617c1 |
What's the integration test looks like? Concurrently drop an unknown user? |
|
cherry pick to release-3.0 in PR #14272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
in #11201 we add
releaseSysSessionmethod to reuse transaction restrict session.but it have potential to release a uncommit session to sessionPool
What is changed and how it works?
force rollback session before release to session pool.
close session directly if session rollback failed.
Check List
Tests
Code changes
Side effects
Related changes
Release note
This change is