Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: add rollback in releaseSysSession (#14269) #14272

Merged
merged 1 commit into from
Dec 27, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Dec 27, 2019

cherry-pick #14269 to release-3.0


What problem does this PR solve?

in #11201 we add releaseSysSession method to reuse transaction restrict session.

but it have potential to release a uncommit session to sessionPool

What is changed and how it works?

force rollback session before release to session pool.
close session directly if session rollback failed.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • add a rollback call

Side effects

  • n/a

Related changes

  • cherry-pick to 3.0

Release note

  • n/a

This change is Reviewable

@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 27, 2019

/run-all-tests

@sre-bot sre-bot added component/server Priority/P1 Features that will be implemented in the latest or next major/minor version priority/release-blocker This PR blocks a release. Please review it ASAP. type/3.0 cherry-pick type/bug-fix This PR fixes a bug. labels Dec 27, 2019
@coocood
Copy link
Member

coocood commented Dec 27, 2019

LGTM

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Dec 27, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 27, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Dec 27, 2019

/run-all-tests

@coocood coocood merged commit 8f13cf1 into pingcap:release-3.0 Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/server Priority/P1 Features that will be implemented in the latest or next major/minor version priority/release-blocker This PR blocks a release. Please review it ASAP. status/can-merge Indicates a PR has been approved by a committer. type/bug-fix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants