Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: update the error message of "modify/change column" to make it easier to understand (#13457) #13796

Merged
merged 3 commits into from
Dec 3, 2019

Conversation

zimulala
Copy link
Contributor

Cherry-pick #13457 to v3.0
conflicts:

  • ddl/column_test.go

  • ddl/db_change_test.go

  • ddl/ddl_api.go

Release note

Update the error message of "modify/change column"

@zimulala zimulala requested review from tangenta and bb7133 and removed request for tangenta November 28, 2019 07:01
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 28, 2019
tangenta
tangenta previously approved these changes Dec 2, 2019
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 2, 2019
@zimulala zimulala added the status/can-merge Indicates a PR has been approved by a committer. label Dec 2, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 2, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 2, 2019

@zimulala merge failed.

@zimulala
Copy link
Contributor Author

zimulala commented Dec 3, 2019

/run-all-tests

@zimulala zimulala merged commit 599d1c4 into pingcap:release-3.0 Dec 3, 2019
@zimulala zimulala deleted the modify-col-err branch December 3, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants