Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: analyze use NewSelectResult #4667

Merged
merged 3 commits into from
Sep 28, 2017
Merged

executor: analyze use NewSelectResult #4667

merged 3 commits into from
Sep 28, 2017

Conversation

winoros
Copy link
Member

@winoros winoros commented Sep 27, 2017

Add NextRaw method for NewSelectResult and use requestBuilder to build analyze request.
And switch analyze's result from old SelectResult to NewSelectResult
And clean up.
PTAL @hanfei1991 @coocood @lamxTyler

@hanfei1991
Copy link
Member

We can remove NextRaw in old logic ?

@winoros
Copy link
Member Author

winoros commented Sep 27, 2017

Yes, i'll do it in the next commit.

@hanfei1991
Copy link
Member

LGTM

@hanfei1991 hanfei1991 added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 28, 2017
coocood
coocood approved these changes Sep 28, 2017
View reviewed changes
Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood merged commit d1d78b7 into master Sep 28, 2017
@coocood coocood deleted the yiding/nextraw branch September 28, 2017 05:07
tiancaiamao added a commit that referenced this pull request Sep 28, 2017
@tiancaiamao
Revert "executor: analyze use NewSelectResult (#4667)"
00bfd37 
This reverts commit d1d78b7.
hanfei1991 pushed a commit that referenced this pull request Sep 28, 2017
@tiancaiamao @hanfei1991
*: revert 4669 "make prepare stmt retriable when schema is out-dated" (…
e3ab386 
…#4676)

* Revert "executor: analyze use NewSelectResult (#4667)"

This reverts commit d1d78b7.

* Revert "table: Speed up the add index operation (#4632)"

This reverts commit d782ce1.

* Revert "*: make prepare stmt retriable when schema is out-dated. (#4669)"

This reverts commit 3dfbf52.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coocood coocood coocood approved these changes

Assignees
No one assigned
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@winoros @hanfei1991 @coocood