New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: analyze use NewSelectResult #4667

Merged
merged 3 commits into from Sep 28, 2017

Conversation

Projects
None yet
3 participants
@winoros
Member

winoros commented Sep 27, 2017

Add NextRaw method for NewSelectResult and use requestBuilder to build analyze request.
And switch analyze's result from old SelectResult to NewSelectResult
And clean up.
PTAL @hanfei1991 @coocood @lamxTyler

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Sep 27, 2017

Member

We can remove NextRaw in old logic ?

Member

hanfei1991 commented Sep 27, 2017

We can remove NextRaw in old logic ?

@winoros

This comment has been minimized.

Show comment
Hide comment
@winoros

winoros Sep 27, 2017

Member

Yes, i'll do it in the next commit.

Member

winoros commented Sep 27, 2017

Yes, i'll do it in the next commit.

@hanfei1991

This comment has been minimized.

Show comment
Hide comment
@hanfei1991

hanfei1991 Sep 28, 2017

Member

LGTM

Member

hanfei1991 commented Sep 28, 2017

LGTM

@coocood

LGTM

@coocood coocood merged commit d1d78b7 into master Sep 28, 2017

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
coverage/coveralls First build on master at 72.693%
Details
jenkins-ci-tidb/build Jenkins job succeeded.
Details
license/cla Contributor License Agreement is signed.
Details

@coocood coocood deleted the yiding/nextraw branch Sep 28, 2017

tiancaiamao added a commit that referenced this pull request Sep 28, 2017

hanfei1991 added a commit that referenced this pull request Sep 28, 2017

*: revert 4669 "make prepare stmt retriable when schema is out-dated" (
…#4676)

* Revert "executor: analyze use NewSelectResult (#4667)"

This reverts commit d1d78b7.

* Revert "table: Speed up the add index operation (#4632)"

This reverts commit d782ce1.

* Revert "*: make prepare stmt retriable when schema is out-dated. (#4669)"

This reverts commit 3dfbf52.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment